infra/bots/recipe_modules/flavor/gn_android_flavor.py - Issue 2334223003: Android GN: don't reboot before running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/flavor/gn_android_flavor.py

Issue 2334223003: Android GN: don't reboot before running (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipe_modules/flavor/gn_android_flavor.py

diff --git a/infra/bots/recipe_modules/flavor/gn_android_flavor.py b/infra/bots/recipe_modules/flavor/gn_android_flavor.py

index 2782bff226654d3f576e323ea0f07e4998b91dfc..1f66e4c3fa7ebab442a8ad2f69d2357e7ad6df08 100644

--- a/infra/bots/recipe_modules/flavor/gn_android_flavor.py

+++ b/infra/bots/recipe_modules/flavor/gn_android_flavor.py

@@ -61,14 +61,12 @@ class GNAndroidFlavorUtils(default_flavor.DefaultFlavorUtils):

self._run('ninja', 'ninja', '-C', self.out_dir)

def install(self):

- self._adb('reboot', 'reboot')

- self._adb('wait for device', 'wait-for-usb-device')

self._adb('mkdir /data/local/tmp/resources',

'shell', 'mkdir', '-p', '/data/local/tmp/resources')

def cleanup_steps(self):

if self._ever_ran_adb:

- self._adb('TEMPORARY reboot', 'reboot')

+ self._adb('reboot', 'reboot')

self._adb('kill adb server', 'kill-server')

def step(self, name, cmd, env=None, **kwargs):