Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2334203002: Reland of GPU driver bug list: remove the use program after link workaround (Closed)

Created:
4 years, 3 months ago by Corentin Wallez
Modified:
4 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of GPU driver bug list: remove the use program after link workaround (patchset #2 id:100001 of https://codereview.chromium.org/2326553004/ ) Reason for revert: Revert didn't help. Original issue's description: > Revert of GPU driver bug list: remove the use program after link workaround (patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ ) > > Reason for revert: > Potential regression https://bugs.chromium.org/p/chromium/issues/detail?id=645498 > > Original issue's description: > > GPU driver bug list: remove the use program after link workaround > > > > The origins of this workaround go waaaaay in the past and seem to > > contradict themselves (only OSX, vs. not OSX) > > > > BUG=590870 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6 > > Cr-Commit-Position: refs/heads/master@{#417397} > > TBR=zmo@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=590870 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/ed7c9c148e43cb09bcef26c131bd445a1d0be078 > Cr-Commit-Position: refs/heads/master@{#417930} TBR=zmo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590870 Committed: https://crrev.com/0f569fe159454c63b60782fbaa1d37caa9f32ec3 Cr-Commit-Position: refs/heads/master@{#418251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -21 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Corentin Wallez
Created Reland of GPU driver bug list: remove the use program after link workaround
4 years, 3 months ago (2016-09-13 14:01:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334203002/1
4 years, 3 months ago (2016-09-13 14:02:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 15:16:02 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 15:17:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f569fe159454c63b60782fbaa1d37caa9f32ec3
Cr-Commit-Position: refs/heads/master@{#418251}

Powered by Google App Engine
This is Rietveld 408576698