Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2334193002: [turbofan] Properly use MachineRepresentation for field access. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly use MachineRepresentation for field access. When lowering DataField accesses, we should pay attention to the MachineRepresentation reported by the AccessInfo. This doesn't yet change the rest of the pipeline to take full advantage of the representations. Drive-by-fix: Make the code more robust, especially the part that deals with mutable heap number access. R=mvstanton@chromium.org BUG=v8:5267, v8:5270 Committed: https://crrev.com/0fb92f273526f105adabd63dda92ebc44192dc27 Cr-Commit-Position: refs/heads/master@{#39381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -59 lines) Patch
M src/compiler/js-native-context-specialization.cc View 3 chunks +92 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-13 12:01:34 UTC) #1
Benedikt Meurer
Hey Michael, Some cleanup on the representation vs. type mess I created previously in JSNativeContextSpecialization. ...
4 years, 3 months ago (2016-09-13 12:02:29 UTC) #4
mvstanton
Okay, great. lgtm.
4 years, 3 months ago (2016-09-13 12:06:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334193002/1
4 years, 3 months ago (2016-09-13 12:17:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 12:24:22 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0fb92f273526f105adabd63dda92ebc44192dc27 Cr-Commit-Position: refs/heads/master@{#39381}
4 years, 3 months ago (2016-09-13 12:25:11 UTC) #11
mvstanton
4 years, 3 months ago (2016-09-13 12:25:29 UTC) #12
Message was sent while issue was closed.
lgtm, thanks for spreading the new representations :). I'm getting my CL from
last week ready...

Powered by Google App Engine
This is Rietveld 408576698