Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2334173002: Clean up WebRTC related includes files in content. (Closed)

Created:
4 years, 3 months ago by Shouqun1
Modified:
4 years, 3 months ago
Reviewers:
esprehn, mcasas
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up WebRTC related includes files in content. AecDumpMessageFilter should not be included if enable_webrtc=false. BUG=642210 TEST= Committed: https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df Cr-Commit-Position: refs/heads/master@{#418499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M content/renderer/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Shouqun1
PTAL, thanks!
4 years, 3 months ago (2016-09-13 11:50:43 UTC) #2
esprehn
lgtm
4 years, 3 months ago (2016-09-13 17:35:13 UTC) #3
mcasas
lgtm if bots are happy it might be interesting to get all those webrtc-specific //content/renderer ...
4 years, 3 months ago (2016-09-13 18:33:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334173002/1
4 years, 3 months ago (2016-09-14 04:55:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 05:59:17 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 06:02:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/517b1298eb6d07a30f07eade189a792c880c00df
Cr-Commit-Position: refs/heads/master@{#418499}

Powered by Google App Engine
This is Rietveld 408576698