Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 2334163006: Revert of [inspector] removed ArrayLengthHelperFunction specialization for empty array (Closed)

Created:
4 years, 3 months ago by Michael Hablich
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] removed ArrayLengthHelperFunction specialization for empty array (patchset #2 id:20001 of https://codereview.chromium.org/2340623002/ ) Reason for revert: needed to revert https://codereview.chromium.org/2339173004/ Original issue's description: > [inspector] removed ArrayLengthHelperFunction specialization for empty array > > There is no zero length array usage in inspector codebase. We can safely remove template specialization. > > BUG=chromium:635948 > R=dgozman@chromium.org,alph@chromium.org > > Committed: https://crrev.com/b249ffc1915d8c35ff66eae3d51d3878d588dfbf > Cr-Commit-Position: refs/heads/master@{#39428} TBR=jochen@chromium.org,alph@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Committed: https://crrev.com/cb891cb06a430b35d466574cdbe7ccdecf6fe3fe Cr-Commit-Position: refs/heads/master@{#39431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/inspector/Allocator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [inspector] removed ArrayLengthHelperFunction specialization for empty array
4 years, 3 months ago (2016-09-15 00:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334163006/1
4 years, 3 months ago (2016-09-15 00:38:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 00:38:43 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 00:38:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb891cb06a430b35d466574cdbe7ccdecf6fe3fe
Cr-Commit-Position: refs/heads/master@{#39431}

Powered by Google App Engine
This is Rietveld 408576698