Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3540)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java

Issue 2334163003: Fix an issue when parsing extension from file name with white spaces (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
index 91fe99d42ac21f1da611b969f94f09c282aad392..973edc5e535ec7ec3c63e46ce5f21df53c98ec63 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
@@ -67,4 +67,14 @@ public class ChromeDownloadDelegateTest extends ChromeActivityTestCaseBase<Chrom
assertFalse(delegate.shouldInterceptContextMenuDownload("http://test/test.dd"));
assertTrue(delegate.shouldInterceptContextMenuDownload("https://test/test.dm"));
}
+
+ @SmallTest
+ @Feature({"Download"})
+ public void testGetFileExtension() {
+ assertEquals("ext", ChromeDownloadDelegate.getFileExtension("", "file.ext"));
+ assertEquals("ext", ChromeDownloadDelegate.getFileExtension("http://file.ext", ""));
+ assertEquals("txt", ChromeDownloadDelegate.getFileExtension("http://file.ext", "file.txt"));
+ assertEquals("txt", ChromeDownloadDelegate.getFileExtension(
+ "http://file.ext", "file name.txt"));
+ }
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698