Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2334143002: Fix BreakingContext::rewindToMidWordBreak to set m_currentCharacterIsSpace (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BreakingContext::rewindToMidWordBreak to set m_currentCharacterIsSpace This patch fixes BreakingContext::rewindToMidWordBreak to set m_currentCharacterIsSpace correctly when it rewinded m_current. Not doing so sets previousCharacterIsSpace incorrectly, and can collapse whitespaces that should not be collapsed. BUG=639781 Committed: https://crrev.com/d5bcb937b6dd019905eb7bbd9834b1eb26213f2a Cr-Commit-Position: refs/heads/master@{#418776}

Patch Set 1 #

Patch Set 2 : WIP: midWordBreak #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/text/break-word-with-floats.html View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/break-word-with-floats-expected.html View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kojii
PTAL.
4 years, 3 months ago (2016-09-13 16:26:37 UTC) #5
eae
OK, LGTM!
4 years, 3 months ago (2016-09-14 22:11:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334143002/40001
4 years, 3 months ago (2016-09-15 03:11:45 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 04:16:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 04:19:10 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5bcb937b6dd019905eb7bbd9834b1eb26213f2a
Cr-Commit-Position: refs/heads/master@{#418776}

Powered by Google App Engine
This is Rietveld 408576698