Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2334123006: scheduler: Don't throttle 0x0 frames (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 5c51f1e212998dd760c4f4724ec035449ebceab5..f6d8df4957542e60f134642ad4869cb670e9d01f 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -4239,9 +4239,10 @@ void FrameView::updateViewportIntersectionsForSubtree(DocumentLifecycle::Lifecyc
void FrameView::updateThrottlingStatus()
{
- // Only offscreen frames can be throttled.
+ // Only offscreen frames can be throttled. Note that we disallow throttling
+ // of 0x0 frames because some sites use them to drive UI logic.
DCHECK(m_viewportIntersectionValid);
- m_hiddenForThrottling = m_viewportIntersection.isEmpty();
+ m_hiddenForThrottling = m_viewportIntersection.isEmpty() && !frameRect().isEmpty();
// We only throttle the rendering pipeline in cross-origin frames. This is
// to avoid a situation where an ancestor frame directly depends on the
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698