Let slimmingPaintInvalidation plumbing work for spv1

Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests --additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation paint/invalidation
Ran 838 tests, 3 crashes, 151 failures.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f47b481212e5451098922c4b94b7fd27334a7bb9
Cr-Commit-Position: refs/heads/master@{#418412}

[Xianzhu, 2016-09-13 05:01:28]

Description was changed from

==========
Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation


BUG=646176
==========

to

==========
Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation


BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-13 05:02:24]

Description was changed from

==========
Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation


BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation
Ran 838 tests, 3 crashes, 151 failures.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-13 05:02:37]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 05:02:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-13 05:05:32]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-09-13 05:16:13]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 05:16:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 07:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 07:23:05]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-09-13 18:45:17]

Q: are you proposing to launch this feature configuration?

[Xianzhu, 2016-09-13 19:30:29]

On 2016/09/13 18:45:17, chrishtr wrote:
> Q: are you proposing to launch this feature configuration?

I'm not very sure about whether to launch it eventually, but it seems a
reachable goal to make pre-paint-tree-walk work for spv1 with reasonable effort.
Just reviewed the early discussions of Q3 okr
(https://groups.google.com/a/chromium.org/forum/#!searchin/paint-dev/okr/paint...),
and it seems that we can achieve some goals of option A (maybe not in Q3)
without much delaying goals of option B, and get some benefits of option A.

Wdyt?

[chrishtr, 2016-09-13 22:38:01]

On 2016/09/13 at 19:30:29, wangxianzhu wrote:
> On 2016/09/13 18:45:17, chrishtr wrote:
> > Q: are you proposing to launch this feature configuration?
> 
> I'm not very sure about whether to launch it eventually, but it seems a
reachable goal to make pre-paint-tree-walk work for spv1 with reasonable effort.
Just reviewed the early discussions of Q3 okr
(https://groups.google.com/a/chromium.org/forum/#!searchin/paint-dev/okr/paint...),
and it seems that we can achieve some goals of option A (maybe not in Q3)
without much delaying goals of option B, and get some benefits of option A.
> 
> Wdyt?

I do agree. Which goals in particular do you think are the best to aim for?

[Xianzhu, 2016-09-13 23:08:55]

On 2016/09/13 22:38:01, chrishtr wrote:
> On 2016/09/13 at 19:30:29, wangxianzhu wrote:
> > On 2016/09/13 18:45:17, chrishtr wrote:
> > > Q: are you proposing to launch this feature configuration?
> > 
> > I'm not very sure about whether to launch it eventually, but it seems a
> reachable goal to make pre-paint-tree-walk work for spv1 with reasonable
effort.
> Just reviewed the early discussions of Q3 okr
>
(https://groups.google.com/a/chromium.org/forum/#!searchin/paint-dev/okr/paint...),
> and it seems that we can achieve some goals of option A (maybe not in Q3)
> without much delaying goals of option B, and get some benefits of option A.
> > 
> > Wdyt?
> 
> I do agree. Which goals in particular do you think are the best to aim for?

1. Make all layout tests pass with
--enable-blink-features=slimmingPaintInvalidation;
2. Launch field trial in dev and/or beta to test performance and stability of
the feature;
3. If performance and stability are good, launch it to stable; or fix the
problems.

[chrishtr, 2016-09-13 23:24:05]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-13 23:24:06]

lgtm

Sounds great! Let's do it.

[commit-bot: I haz the power, 2016-09-13 23:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 23:34:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 23:36:33]

Description was changed from

==========
Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation
Ran 838 tests, 3 crashes, 151 failures.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Let slimmingPaintInvalidation plumbing work for spv1

This Cl elimimates all DCHECK failures about document lifecycle,
code path, etc.

Test: run-webkit-tests
--additional-driver-flag=--enable-blink-features=slimmingPaintInvalidation
paint/invalidation
Ran 838 tests, 3 crashes, 151 failures.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f47b481212e5451098922c4b94b7fd27334a7bb9
Cr-Commit-Position: refs/heads/master@{#418412}
==========

[commit-bot: I haz the power, 2016-09-13 23:36:34]

Patchset 2 (id:??) landed as
https://crrev.com/f47b481212e5451098922c4b94b7fd27334a7bb9
Cr-Commit-Position: refs/heads/master@{#418412}