Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2334073002: DevTools: Show a red background under unmatched brackets (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
chowse, lushnikov, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show a red background under unmatched brackets Also stop matched brackets from breaking through syntax highlighting. BUG=none Committed: https://crrev.com/acc8ce6ac31a3de314a10e8fc590910624b31783 Cr-Commit-Position: refs/heads/master@{#418749}

Patch Set 1 #

Patch Set 2 : Dark mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 1 1 chunk +16 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlightDark.css View 1 3 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
einbinder
ptal http://i.imgur.com/oyzjKFX.png
4 years, 3 months ago (2016-09-13 01:55:59 UTC) #2
pfeldman
lgtm
4 years, 3 months ago (2016-09-13 17:33:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334073002/20001
4 years, 3 months ago (2016-09-15 00:32:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 01:44:46 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:47:03 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/acc8ce6ac31a3de314a10e8fc590910624b31783
Cr-Commit-Position: refs/heads/master@{#418749}

Powered by Google App Engine
This is Rietveld 408576698