Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2334013003: Moves ScreenDimmer to ash/common (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, hashimoto+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves ScreenDimmer to ash/common It no longer has any deps on non-common types. BUG=640781 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/f3bc2db7fd84d02ca6bb0adcc8e72a813df584cc Cr-Commit-Position: refs/heads/master@{#418226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -169 lines) Patch
M ash/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/wm/screen_dimmer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/wm/screen_dimmer.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/wm/screen_dimmer.h View 1 chunk +0 lines, -80 lines 0 comments Download
D ash/wm/screen_dimmer.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
sky
4 years, 3 months ago (2016-09-13 02:36:20 UTC) #1
sky
And I can't move tests over as I need some other functionality added first.
4 years, 3 months ago (2016-09-13 02:37:02 UTC) #2
James Cook
LGTM
4 years, 3 months ago (2016-09-13 04:35:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334013003/1
4 years, 3 months ago (2016-09-13 13:13:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 13:18:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 13:20:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3bc2db7fd84d02ca6bb0adcc8e72a813df584cc
Cr-Commit-Position: refs/heads/master@{#418226}

Powered by Google App Engine
This is Rietveld 408576698