Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2334003006: Merges two options reset overlay classes (Closed)

Created:
4 years, 3 months ago by alito
Modified:
4 years, 3 months ago
Reviewers:
robertshield, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merges two options reset overlay classes This merges ResetProfileSettingsOverlay and TriggeredResetProfileSettingsOverlay into a single class. BUG=636435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7410211a6122f9b5a6b4dd22f0a85bbd9dab8ddf Cr-Commit-Position: refs/heads/master@{#418876}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed dbeam's comments #

Total comments: 2

Patch Set 3 : Fix variable name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -78 lines) Patch
M chrome/browser/resources/options/options.js View 1 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.js View 1 2 2 chunks +45 lines, -22 lines 0 comments Download
D chrome/browser/resources/options/triggered_reset_profile_settings_overlay.js View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
alito
Dan, could you PTAL? Thank you!
4 years, 3 months ago (2016-09-14 21:06:39 UTC) #12
Dan Beam
https://codereview.chromium.org/2334003006/diff/1/chrome/browser/resources/options/options.js File chrome/browser/resources/options/options.js (right): https://codereview.chromium.org/2334003006/diff/1/chrome/browser/resources/options/options.js#newcode167 chrome/browser/resources/options/options.js:167: new ResetProfileSettingsOverlay(false), new ResetProfileSettingsOverlay(false /* isTriggered */) https://codereview.chromium.org/2334003006/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.js File ...
4 years, 3 months ago (2016-09-14 21:22:38 UTC) #13
Dan Beam
can you add a BUG=? https://codereview.chromium.org/2334003006/diff/20001/chrome/browser/resources/options/reset_profile_settings_overlay.js File chrome/browser/resources/options/reset_profile_settings_overlay.js (right): https://codereview.chromium.org/2334003006/diff/20001/chrome/browser/resources/options/reset_profile_settings_overlay.js#newcode80 chrome/browser/resources/options/reset_profile_settings_overlay.js:80: 'resetProfileSettingsOverlay'); this needs to ...
4 years, 3 months ago (2016-09-14 21:54:48 UTC) #14
alito
Addressed Dan's comments. https://codereview.chromium.org/2334003006/diff/1/chrome/browser/resources/options/options.js File chrome/browser/resources/options/options.js (right): https://codereview.chromium.org/2334003006/diff/1/chrome/browser/resources/options/options.js#newcode167 chrome/browser/resources/options/options.js:167: new ResetProfileSettingsOverlay(false), On 2016/09/14 21:22:37, Dan ...
4 years, 3 months ago (2016-09-14 23:37:46 UTC) #16
alito
Adding Robert who wrote the original triggered reset overlay.
4 years, 3 months ago (2016-09-15 00:21:53 UTC) #22
Dan Beam
lgtm
4 years, 3 months ago (2016-09-15 00:24:00 UTC) #23
robertshield
lgtm
4 years, 3 months ago (2016-09-15 03:03:04 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334003006/40001
4 years, 3 months ago (2016-09-15 15:11:07 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 15:54:50 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:01:54 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7410211a6122f9b5a6b4dd22f0a85bbd9dab8ddf
Cr-Commit-Position: refs/heads/master@{#418876}

Powered by Google App Engine
This is Rietveld 408576698