Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2334003004: Show the fetch handler existence in chrome://serviceworker-internals (Closed)

Created:
4 years, 3 months ago by horo
Modified:
4 years, 3 months ago
Reviewers:
shimazu
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the fetch handler existence in chrome://serviceworker-internals BUG= Committed: https://crrev.com/605a64eebfd68e807e6a8d5232d7386946c26438 Cr-Commit-Position: refs/heads/master@{#418509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M content/browser/resources/service_worker/serviceworker_internals.html View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_info.h View 1 chunk +11 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_info.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
horo
shimazu@ Could you please review?
4 years, 3 months ago (2016-09-14 04:07:00 UTC) #4
horo
shimazu@ Could you please review?
4 years, 3 months ago (2016-09-14 04:07:01 UTC) #5
shimazu
lgtm! Do we have some plan to show this on DevTools?
4 years, 3 months ago (2016-09-14 06:46:46 UTC) #8
horo
On 2016/09/14 06:46:46, shimazu wrote: > lgtm! > Do we have some plan to show ...
4 years, 3 months ago (2016-09-14 07:55:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334003004/1
4 years, 3 months ago (2016-09-14 07:56:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 08:01:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 08:04:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/605a64eebfd68e807e6a8d5232d7386946c26438
Cr-Commit-Position: refs/heads/master@{#418509}

Powered by Google App Engine
This is Rietveld 408576698