cc : Compute visible rects dynamically (1)

cc/trees/layer_tree_host_common.cc

Index: cc/trees/layer_tree_host_common.cc
diff --git a/cc/trees/layer_tree_host_common.cc b/cc/trees/layer_tree_host_common.cc
index 047c758bc39d6347f5699aa031be34ff84f49519..6e1b45cd4690552e65cdd9d62b1872fd39e0f5d8 100644
--- a/cc/trees/layer_tree_host_common.cc
+++ b/cc/trees/layer_tree_host_common.cc
@@ -83,6 +83,7 @@ LayerTreeHostCommon::CalcDrawPropsImplInputs::CalcDrawPropsImplInputs(
     bool can_render_to_separate_surface,
     bool can_adjust_raster_scales,
     bool verify_clip_tree_calculations,
+    bool verify_visible_rect_calculations,
     bool verify_transform_tree_calculations,
     LayerImplList* render_surface_layer_list,
     PropertyTrees* property_trees)
@@ -101,6 +102,7 @@ LayerTreeHostCommon::CalcDrawPropsImplInputs::CalcDrawPropsImplInputs(
       can_render_to_separate_surface(can_render_to_separate_surface),
       can_adjust_raster_scales(can_adjust_raster_scales),
       verify_clip_tree_calculations(verify_clip_tree_calculations),
+      verify_visible_rect_calculations(verify_visible_rect_calculations),
       verify_transform_tree_calculations(verify_transform_tree_calculations),
       render_surface_layer_list(render_surface_layer_list),
       property_trees(property_trees) {}
@@ -126,6 +128,7 @@ LayerTreeHostCommon::CalcDrawPropsImplInputsForTesting::
                               false,
                               true,
                               true,
+                              true,
                               render_surface_layer_list,
                               GetPropertyTrees(root_layer)) {
   DCHECK(root_layer);
@@ -555,7 +558,8 @@ void CalculateDrawPropertiesInternal(
           inputs->elastic_overscroll, inputs->page_scale_factor,
           inputs->device_scale_factor, gfx::Rect(inputs->device_viewport_size),
           inputs->device_transform, inputs->can_render_to_separate_surface,
-          inputs->property_trees, &visible_layer_list);
+          inputs->verify_visible_rect_calculations, inputs->property_trees,
+          &visible_layer_list);
 
       // Property trees are normally constructed on the main thread and
       // passed to compositor thread. Source to parent updates on them are not
@@ -597,7 +601,8 @@ void CalculateDrawPropertiesInternal(
           inputs->device_transform);
       draw_property_utils::ComputeVisibleRects(
           inputs->root_layer, inputs->property_trees,
-          inputs->can_render_to_separate_surface, &visible_layer_list);
+          inputs->can_render_to_separate_surface,
+          inputs->verify_visible_rect_calculations, &visible_layer_list);

[weiliangc, 2016/09/19 21:16:44]

I think if you use (inputs->verify_clip_tree_calculations &&
inputs->verify_visible_rect_calculations) you could avoid adding one more bool
to LayerTreeSettings?

[jaydasika, 2016/09/19 21:55:01]

Done with a small change. Instead of using
(inputs->verify_clip_tree_calculations &&
inputs->verify_visible_rect_calculations) here, I have made the caller
responsible for setting the right value of
inputs->verify_visible_rect_calculations, so that its not confusing.

       break;
     }
   }