cc : Compute visible rects dynamically (1)

cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b
Cr-Commit-Position: refs/heads/master@{#419628}

[jaydasika, 2016-09-13 22:57:18]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out (we early out for copy requests, singular transforms etc) in visible
rect computation and compares it with the current computation. This
dynamic computation is behind the 'verify_clip_tree_calculations' flag

BUG=642054
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out (we early out for copy requests, singular transforms etc) in visible
rect computation and compares it with the current computation. This
dynamic computation is behind the 'verify_clip_tree_calculations' flag

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-14 18:10:43]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out (we early out for copy requests, singular transforms etc) in visible
rect computation and compares it with the current computation. This
dynamic computation is behind the 'verify_clip_tree_calculations' flag

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for copy
requests, singular transforms etc) in visible
rect computation and compares it with the current computation. This
dynamic computation is behind the 'verify_clip_tree_calculations' flag.

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-14 18:13:06]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for copy
requests, singular transforms etc) in visible
rect computation and compares it with the current computation. This
dynamic computation is behind the 'verify_clip_tree_calculations' flag.

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) in visible rect computation 
and compares it with the current computation. This dynamic
computation
is behind the 'verify_clip_tree_calculations' flag. This CL also skips
verify_clip_tree_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-14 18:13:23]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) in visible rect computation 
and compares it with the current computation. This dynamic
computation
is behind the 'verify_clip_tree_calculations' flag. This CL also skips
verify_clip_tree_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) in visible rect computation 
and compares it with the current computation. This dynamic computation
is behind the 'verify_clip_tree_calculations' flag. This CL also skips
verify_clip_tree_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-14 18:14:20]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) in visible rect computation 
and compares it with the current computation. This dynamic computation
is behind the 'verify_clip_tree_calculations' flag. This CL also skips
verify_clip_tree_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the 
'verify_clip_tree_calculations' flag. This CL also skips
verify_clip_tree_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-14 18:15:06]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-09-14 18:15:07]

PTAL

[jaydasika, 2016-09-14 18:45:36]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 18:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:09:03]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2016-09-14 21:12:26]

Hmm, I'm not too happy about how many function now has the skip_verify bool. I
guess adding a second bool to verify vis_rect calculation would be equally
convoluted?

Maybe this is the only way forward. I'll have to think a bit more and will reply
tomorrow.

[weiliangc, 2016-09-15 21:47:31]

The calculations looks good. For testing, I am thinking maybe add a bool to
CalcDrawPropsImplInputs to expect_visible_rect_mismatch? There would be more
plumbing, but we would still be doing the calculations. WDYT?

[jaydasika, 2016-09-15 21:56:49]

On 2016/09/15 21:47:31, weiliangc wrote:
> The calculations looks good. For testing, I am thinking maybe add a bool to
> CalcDrawPropsImplInputs to expect_visible_rect_mismatch? There would be more
> plumbing, but we would still be doing the calculations. WDYT?

If the aim is to run the new calculations for these tests where they don't
match,
we could just call ComputeLayerVisibleRectDynamic from these tests. That would
save us all the extra plumbing.

[weiliangc, 2016-09-15 22:21:30]

The aim is to still compare clip rect calculation when visible rect
calculation do not match.

And if we are able to categorize what are the cases we expect to fail we
could try running more than unittests? This point is somewhat speculative.

On Thu, Sep 15, 2016, 5:56 PM <jaydasika@chromium.org> wrote:

> On 2016/09/15 21:47:31, weiliangc wrote:
> > The calculations looks good. For testing, I am thinking maybe add a bool
> to
> > CalcDrawPropsImplInputs to expect_visible_rect_mismatch? There would be
> more
> > plumbing, but we would still be doing the calculations. WDYT?
>
> If the aim is to run the new calculations for these tests where they don't
> match,
> we could just call ComputeLayerVisibleRectDynamic from these tests. That
> would
> save us all the extra plumbing.
>
> https://codereview.chromium.org/2334003003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jaydasika, 2016-09-16 22:20:15]

Added a new flag for verifying visible rect calculations

https://codereview.chromium.org/2334003003/diff/80001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl_unittest.cc (right):

https://codereview.chromium.org/2334003003/diff/80001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl_unittest.cc:675:
skip_verify_visible_rect_calculations);
I am not checking visible rects computed dynamically here as this is a hit
testing test and its not effected by visible rects.

[jaydasika, 2016-09-16 22:20:28]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2016-09-16 22:21:00]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the 
'verify_clip_tree_calculations' flag. This CL also skips
verify_clip_tree_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the 
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-16 22:21:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-09-16 22:35:31]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:02:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:02:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jaydasika, 2016-09-17 00:59:09]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 00:59:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:28:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jaydasika, 2016-09-19 18:01:57]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:02:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:30:31]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jaydasika, 2016-09-19 20:12:41]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-09-19 20:14:48]

Rebase + make cc_perftests compile.

[commit-bot: I haz the power, 2016-09-19 21:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:01:57]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2016-09-19 21:16:45]

LGTM w/ a possible suggestion.

https://codereview.chromium.org/2334003003/diff/140001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/2334003003/diff/140001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:605:
inputs->verify_visible_rect_calculations, &visible_layer_list);
I think if you use (inputs->verify_clip_tree_calculations &&
inputs->verify_visible_rect_calculations) you could avoid adding one more bool
to LayerTreeSettings?

[jaydasika, 2016-09-19 21:52:48]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-09-19 21:55:01]

https://codereview.chromium.org/2334003003/diff/140001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/2334003003/diff/140001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:605:
inputs->verify_visible_rect_calculations, &visible_layer_list);
On 2016/09/19 21:16:44, weiliangc wrote:
> I think if you use (inputs->verify_clip_tree_calculations &&
> inputs->verify_visible_rect_calculations) you could avoid adding one more bool
> to LayerTreeSettings?
> 

Done with a small change. Instead of using
(inputs->verify_clip_tree_calculations &&
inputs->verify_visible_rect_calculations) here, I have made the caller
responsible for setting the right value of
inputs->verify_visible_rect_calculations, so that its not confusing.

[commit-bot: I haz the power, 2016-09-19 23:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 23:57:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jaydasika, 2016-09-20 00:06:16]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-09-20 00:06:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
weiliangc@chromium.org
Link to the patchset: https://codereview.chromium.org/2334003003/#ps160001
(title: "comment")

[commit-bot: I haz the power, 2016-09-20 00:06:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:34:51]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the 
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the 
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-20 01:34:52]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-20 01:38:10]

Description was changed from

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for 
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the 
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Compute visible rects dynamically (1)

This CL computes visible rects dynamically for all cases we don't early
out in draw_property_utils::CalculateVisibleRects (we early out for
copy requests, singular transforms etc) and compares it with the
current computation. This dynamic computation is behind the
'verify_visible_rectcalculations' flag. This CL also skips
verify_visible_rect_calculations for some test where we expect the
visible rects computed by the two methods to be different

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b
Cr-Commit-Position: refs/heads/master@{#419628}
==========

[commit-bot: I haz the power, 2016-09-20 01:38:11]

Patchset 9 (id:??) landed as
https://crrev.com/5237db09cd8a30328742e4f6b1ee2edb692e936b
Cr-Commit-Position: refs/heads/master@{#419628}