Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 23340003: Fix stack buffer read overflow in GrConvolutionEffect::TestCreate. (Closed)

Created:
7 years, 4 months ago by bungeman-skia
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix stack buffer read overflow in GrConvolutionEffect::TestCreate. BUG=skia:1532 R=bsalomon@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10816

Patch Set 1 #

Patch Set 2 : Avoid signed / unsigned comparison. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/effects/GrConvolutionEffect.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
7 years, 4 months ago (2013-08-20 15:15:11 UTC) #1
robertphillips
lgtm
7 years, 4 months ago (2013-08-20 15:18:35 UTC) #2
bsalomon
lgtm
7 years, 4 months ago (2013-08-20 15:19:17 UTC) #3
bungeman-skia
7 years, 4 months ago (2013-08-20 15:20:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r10816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698