Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2333973003: [turbofan] Remove remnants from JavaScript stubs support. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove remnants from JavaScript stubs support. This removes some leftover code which avoided adding stack checks to stubs being compiled via the normal JavaScript pipeline, which we no longer do. R=bmeurer@chromium.org Committed: https://crrev.com/4e44264148467f17cebe7db2201df07952c74b3a Cr-Commit-Position: refs/heads/master@{#39404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/pipeline.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-13 14:56:34 UTC) #3
Benedikt Meurer
lgtm Nice.
4 years, 3 months ago (2016-09-13 16:55:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333973003/1
4 years, 3 months ago (2016-09-14 07:56:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 08:19:45 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 08:20:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e44264148467f17cebe7db2201df07952c74b3a
Cr-Commit-Position: refs/heads/master@{#39404}

Powered by Google App Engine
This is Rietveld 408576698