Move String::remove to StringImpl.

Move String::remove to StringImpl.

String should be a thin wrapper over StringImpl and other functions.

I also simplified the implementation if remove() to leverage StringBuffer and
copyChars.

Committed: https://crrev.com/a5600d2e84a879fd03af32b3ebc85241d51e2fed
Cr-Commit-Position: refs/heads/master@{#418116}

[esprehn, 2016-09-12 21:30:53]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:43:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:43:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-09-12 21:59:15]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 22:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-09-12 22:01:25]

Description was changed from

==========
Move String::remove to StringImpl.
==========

to

==========
Move String::remove to StringImpl.

String should be a thin wrapper over StringImpl and other functions.
==========

[esprehn, 2016-09-12 22:01:52]

Description was changed from

==========
Move String::remove to StringImpl.

String should be a thin wrapper over StringImpl and other functions.
==========

to

==========
Move String::remove to StringImpl.

String should be a thin wrapper over StringImpl and other functions.

I also simplified the implementation if remove() to leverage StringBuffer and
copyChars.
==========

[commit-bot: I haz the power, 2016-09-12 23:46:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:46:36]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-09-13 00:10:05]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[haraken, 2016-09-13 00:13:58]

LGTM

[esprehn, 2016-09-13 00:15:38]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-09-13 00:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 00:20:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 00:22:29]

Description was changed from

==========
Move String::remove to StringImpl.

String should be a thin wrapper over StringImpl and other functions.

I also simplified the implementation if remove() to leverage StringBuffer and
copyChars.
==========

to

==========
Move String::remove to StringImpl.

String should be a thin wrapper over StringImpl and other functions.

I also simplified the implementation if remove() to leverage StringBuffer and
copyChars.

Committed: https://crrev.com/a5600d2e84a879fd03af32b3ebc85241d51e2fed
Cr-Commit-Position: refs/heads/master@{#418116}
==========

[commit-bot: I haz the power, 2016-09-13 00:22:31]

Patchset 2 (id:??) landed as
https://crrev.com/a5600d2e84a879fd03af32b3ebc85241d51e2fed
Cr-Commit-Position: refs/heads/master@{#418116}