Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 233393002: Updating the gold location. (Closed)

Created:
6 years, 8 months ago by mithro-old
Modified:
6 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing wrapping. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mithro-old
Hi! We have replaced third_party/gold with a full copy of binutils at third_party/binutils. It gets ...
6 years, 8 months ago (2014-04-10 15:27:35 UTC) #1
brettw
Thanks! LGTM https://codereview.chromium.org/233393002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/233393002/diff/1/build/config/compiler/BUILD.gn#newcode146 build/config/compiler/BUILD.gn:146: gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin", root_build_dir) Can you wrap ...
6 years, 8 months ago (2014-04-10 17:46:33 UTC) #2
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 8 months ago (2014-04-11 02:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/233393002/20001
6 years, 8 months ago (2014-04-11 02:03:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 05:22:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=296033
6 years, 8 months ago (2014-04-11 05:22:41 UTC) #6
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 8 months ago (2014-04-11 05:42:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/233393002/20001
6 years, 8 months ago (2014-04-11 05:44:12 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 07:56:07 UTC) #9
Message was sent while issue was closed.
Change committed as 263185

Powered by Google App Engine
This is Rietveld 408576698