Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2333923008: [turbofan] Ensure AstGraphBuilder::CheckOsrEntry hits once. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ensure AstGraphBuilder::CheckOsrEntry hits once. The predicate in question should only trigger once and hence the stack height should not be updated incrementally. This puts checks into place ensuring this holds. R=bmeurer@chromium.org Committed: https://crrev.com/f8ed6fb151555f11c0c8396c741758741698aa61 Cr-Commit-Position: refs/heads/master@{#39472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compilation-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-16 10:48:07 UTC) #3
Benedikt Meurer
Remove all the defensive programming! LGTM
4 years, 3 months ago (2016-09-16 11:41:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333923008/1
4 years, 3 months ago (2016-09-16 11:54:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 11:57:16 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 11:58:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8ed6fb151555f11c0c8396c741758741698aa61
Cr-Commit-Position: refs/heads/master@{#39472}

Powered by Google App Engine
This is Rietveld 408576698