Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: net/log/net_log_parameters_callback_typedef.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: git rebase-update patch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log_parameters_callback_typedef.h
diff --git a/net/log/net_log_parameters_callback_typedef.h b/net/log/net_log_parameters_callback_typedef.h
new file mode 100644
index 0000000000000000000000000000000000000000..07353277b79f86059ce3d8aa36e00274aabd2e31
--- /dev/null
+++ b/net/log/net_log_parameters_callback_typedef.h
@@ -0,0 +1,28 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_LOG_NET_LOG_PARAMETERS_CALLBACK_TYPEDEF_H_
eroman 2016/10/03 21:40:50 nit on naming: I suggest dropping "_typedef" from
mikecirone 2016/10/03 23:38:25 "net_log_parameters_callback_typedef.h" is now "ne
+#define NET_LOG_NET_LOG_PARAMETERS_CALLBACK_TYPEDEF_H_
+
+#include <memory>
+
+#include "base/callback_forward.h"
+#include "net/log/net_log_capture_mode.h"
+
+namespace base {
+class Value;
+}
+
+namespace net {
+
+// A callback that returns a Value representation of the parameters
+// associated with an event. If called, it will be called synchronously,
+// so it need not have owning references. May be called more than once, or
+// not at all. May return NULL.
eroman 2016/10/03 21:40:50 optional: Can you change NULL --> nullptr while ed
mikecirone 2016/10/03 23:38:25 Done.
+typedef base::Callback<std::unique_ptr<base::Value>(NetLogCaptureMode)>
+ NetLogParametersCallback;
+
+} // namespace net
+
+#endif // NET_LOG_NET_LOG_PARAMETERS_CALLBACK_TYPEDEF_H_

Powered by Google App Engine
This is Rietveld 408576698