Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: net/url_request/url_request_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 #include "net/cookies/cookie_store_test_helpers.h" 70 #include "net/cookies/cookie_store_test_helpers.h"
71 #include "net/disk_cache/disk_cache.h" 71 #include "net/disk_cache/disk_cache.h"
72 #include "net/dns/mock_host_resolver.h" 72 #include "net/dns/mock_host_resolver.h"
73 #include "net/http/http_byte_range.h" 73 #include "net/http/http_byte_range.h"
74 #include "net/http/http_cache.h" 74 #include "net/http/http_cache.h"
75 #include "net/http/http_network_layer.h" 75 #include "net/http/http_network_layer.h"
76 #include "net/http/http_network_session.h" 76 #include "net/http/http_network_session.h"
77 #include "net/http/http_request_headers.h" 77 #include "net/http/http_request_headers.h"
78 #include "net/http/http_response_headers.h" 78 #include "net/http/http_response_headers.h"
79 #include "net/http/http_util.h" 79 #include "net/http/http_util.h"
80 #include "net/log/net_log.h"
81 #include "net/log/net_log_event_type.h" 80 #include "net/log/net_log_event_type.h"
81 #include "net/log/net_log_source.h"
82 #include "net/log/test_net_log.h" 82 #include "net/log/test_net_log.h"
83 #include "net/log/test_net_log_entry.h" 83 #include "net/log/test_net_log_entry.h"
84 #include "net/log/test_net_log_util.h" 84 #include "net/log/test_net_log_util.h"
85 #include "net/nqe/external_estimate_provider.h" 85 #include "net/nqe/external_estimate_provider.h"
86 #include "net/proxy/proxy_service.h" 86 #include "net/proxy/proxy_service.h"
87 #include "net/socket/ssl_client_socket.h" 87 #include "net/socket/ssl_client_socket.h"
88 #include "net/ssl/channel_id_service.h" 88 #include "net/ssl/channel_id_service.h"
89 #include "net/ssl/default_channel_id_store.h" 89 #include "net/ssl/default_channel_id_store.h"
90 #include "net/ssl/ssl_connection_status_flags.h" 90 #include "net/ssl/ssl_connection_status_flags.h"
91 #include "net/ssl/ssl_server_config.h" 91 #include "net/ssl/ssl_server_config.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 #if !defined(DISABLE_FTP_SUPPORT) && !defined(OS_ANDROID) 150 #if !defined(DISABLE_FTP_SUPPORT) && !defined(OS_ANDROID)
151 // Test file used in most FTP tests. 151 // Test file used in most FTP tests.
152 const char kFtpTestFile[] = "BullRunSpeech.txt"; 152 const char kFtpTestFile[] = "BullRunSpeech.txt";
153 #endif 153 #endif
154 154
155 // Tests load timing information in the case a fresh connection was used, with 155 // Tests load timing information in the case a fresh connection was used, with
156 // no proxy. 156 // no proxy.
157 void TestLoadTimingNotReused(const LoadTimingInfo& load_timing_info, 157 void TestLoadTimingNotReused(const LoadTimingInfo& load_timing_info,
158 int connect_timing_flags) { 158 int connect_timing_flags) {
159 EXPECT_FALSE(load_timing_info.socket_reused); 159 EXPECT_FALSE(load_timing_info.socket_reused);
160 EXPECT_NE(NetLog::Source::kInvalidId, load_timing_info.socket_log_id); 160 EXPECT_NE(NetLogSource::kInvalidId, load_timing_info.socket_log_id);
161 161
162 EXPECT_FALSE(load_timing_info.request_start_time.is_null()); 162 EXPECT_FALSE(load_timing_info.request_start_time.is_null());
163 EXPECT_FALSE(load_timing_info.request_start.is_null()); 163 EXPECT_FALSE(load_timing_info.request_start.is_null());
164 164
165 EXPECT_LE(load_timing_info.request_start, 165 EXPECT_LE(load_timing_info.request_start,
166 load_timing_info.connect_timing.connect_start); 166 load_timing_info.connect_timing.connect_start);
167 ExpectConnectTimingHasTimes(load_timing_info.connect_timing, 167 ExpectConnectTimingHasTimes(load_timing_info.connect_timing,
168 connect_timing_flags); 168 connect_timing_flags);
169 EXPECT_LE(load_timing_info.connect_timing.connect_end, 169 EXPECT_LE(load_timing_info.connect_timing.connect_end,
170 load_timing_info.send_start); 170 load_timing_info.send_start);
171 EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end); 171 EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
172 EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end); 172 EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
173 173
174 EXPECT_TRUE(load_timing_info.proxy_resolve_start.is_null()); 174 EXPECT_TRUE(load_timing_info.proxy_resolve_start.is_null());
175 EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null()); 175 EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null());
176 } 176 }
177 177
178 // Same as above, but with proxy times. 178 // Same as above, but with proxy times.
179 void TestLoadTimingNotReusedWithProxy( 179 void TestLoadTimingNotReusedWithProxy(
180 const LoadTimingInfo& load_timing_info, 180 const LoadTimingInfo& load_timing_info,
181 int connect_timing_flags) { 181 int connect_timing_flags) {
182 EXPECT_FALSE(load_timing_info.socket_reused); 182 EXPECT_FALSE(load_timing_info.socket_reused);
183 EXPECT_NE(NetLog::Source::kInvalidId, load_timing_info.socket_log_id); 183 EXPECT_NE(NetLogSource::kInvalidId, load_timing_info.socket_log_id);
184 184
185 EXPECT_FALSE(load_timing_info.request_start_time.is_null()); 185 EXPECT_FALSE(load_timing_info.request_start_time.is_null());
186 EXPECT_FALSE(load_timing_info.request_start.is_null()); 186 EXPECT_FALSE(load_timing_info.request_start.is_null());
187 187
188 EXPECT_LE(load_timing_info.request_start, 188 EXPECT_LE(load_timing_info.request_start,
189 load_timing_info.proxy_resolve_start); 189 load_timing_info.proxy_resolve_start);
190 EXPECT_LE(load_timing_info.proxy_resolve_start, 190 EXPECT_LE(load_timing_info.proxy_resolve_start,
191 load_timing_info.proxy_resolve_end); 191 load_timing_info.proxy_resolve_end);
192 EXPECT_LE(load_timing_info.proxy_resolve_end, 192 EXPECT_LE(load_timing_info.proxy_resolve_end,
193 load_timing_info.connect_timing.connect_start); 193 load_timing_info.connect_timing.connect_start);
194 ExpectConnectTimingHasTimes(load_timing_info.connect_timing, 194 ExpectConnectTimingHasTimes(load_timing_info.connect_timing,
195 connect_timing_flags); 195 connect_timing_flags);
196 EXPECT_LE(load_timing_info.connect_timing.connect_end, 196 EXPECT_LE(load_timing_info.connect_timing.connect_end,
197 load_timing_info.send_start); 197 load_timing_info.send_start);
198 EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end); 198 EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
199 EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end); 199 EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
200 } 200 }
201 201
202 // Same as above, but with a reused socket and proxy times. 202 // Same as above, but with a reused socket and proxy times.
203 void TestLoadTimingReusedWithProxy( 203 void TestLoadTimingReusedWithProxy(
204 const LoadTimingInfo& load_timing_info) { 204 const LoadTimingInfo& load_timing_info) {
205 EXPECT_TRUE(load_timing_info.socket_reused); 205 EXPECT_TRUE(load_timing_info.socket_reused);
206 EXPECT_NE(NetLog::Source::kInvalidId, load_timing_info.socket_log_id); 206 EXPECT_NE(NetLogSource::kInvalidId, load_timing_info.socket_log_id);
207 207
208 EXPECT_FALSE(load_timing_info.request_start_time.is_null()); 208 EXPECT_FALSE(load_timing_info.request_start_time.is_null());
209 EXPECT_FALSE(load_timing_info.request_start.is_null()); 209 EXPECT_FALSE(load_timing_info.request_start.is_null());
210 210
211 ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing); 211 ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing);
212 212
213 EXPECT_LE(load_timing_info.request_start, 213 EXPECT_LE(load_timing_info.request_start,
214 load_timing_info.proxy_resolve_start); 214 load_timing_info.proxy_resolve_start);
215 EXPECT_LE(load_timing_info.proxy_resolve_start, 215 EXPECT_LE(load_timing_info.proxy_resolve_start,
216 load_timing_info.proxy_resolve_end); 216 load_timing_info.proxy_resolve_end);
(...skipping 22 matching lines...) Expand all
239 buffer[i] = static_cast<char>(rand()); 239 buffer[i] = static_cast<char>(rand());
240 if (!buffer[i]) 240 if (!buffer[i])
241 buffer[i] = 'g'; 241 buffer[i] = 'g';
242 } 242 }
243 } 243 }
244 #endif 244 #endif
245 245
246 void TestLoadTimingCacheHitNoNetwork( 246 void TestLoadTimingCacheHitNoNetwork(
247 const LoadTimingInfo& load_timing_info) { 247 const LoadTimingInfo& load_timing_info) {
248 EXPECT_FALSE(load_timing_info.socket_reused); 248 EXPECT_FALSE(load_timing_info.socket_reused);
249 EXPECT_EQ(NetLog::Source::kInvalidId, load_timing_info.socket_log_id); 249 EXPECT_EQ(NetLogSource::kInvalidId, load_timing_info.socket_log_id);
250 250
251 EXPECT_FALSE(load_timing_info.request_start_time.is_null()); 251 EXPECT_FALSE(load_timing_info.request_start_time.is_null());
252 EXPECT_FALSE(load_timing_info.request_start.is_null()); 252 EXPECT_FALSE(load_timing_info.request_start.is_null());
253 253
254 ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing); 254 ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing);
255 EXPECT_LE(load_timing_info.request_start, load_timing_info.send_start); 255 EXPECT_LE(load_timing_info.request_start, load_timing_info.send_start);
256 EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end); 256 EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
257 EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end); 257 EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
258 258
259 EXPECT_TRUE(load_timing_info.proxy_resolve_start.is_null()); 259 EXPECT_TRUE(load_timing_info.proxy_resolve_start.is_null());
260 EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null()); 260 EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null());
261 } 261 }
262 262
263 #if !defined(DISABLE_FTP_SUPPORT) && !defined(OS_ANDROID) 263 #if !defined(DISABLE_FTP_SUPPORT) && !defined(OS_ANDROID)
264 // Tests load timing in the case that there is no HTTP response. This can be 264 // Tests load timing in the case that there is no HTTP response. This can be
265 // used to test in the case of errors or non-HTTP requests. 265 // used to test in the case of errors or non-HTTP requests.
266 void TestLoadTimingNoHttpResponse( 266 void TestLoadTimingNoHttpResponse(
267 const LoadTimingInfo& load_timing_info) { 267 const LoadTimingInfo& load_timing_info) {
268 EXPECT_FALSE(load_timing_info.socket_reused); 268 EXPECT_FALSE(load_timing_info.socket_reused);
269 EXPECT_EQ(NetLog::Source::kInvalidId, load_timing_info.socket_log_id); 269 EXPECT_EQ(NetLogSource::kInvalidId, load_timing_info.socket_log_id);
270 270
271 // Only the request times should be non-null. 271 // Only the request times should be non-null.
272 EXPECT_FALSE(load_timing_info.request_start_time.is_null()); 272 EXPECT_FALSE(load_timing_info.request_start_time.is_null());
273 EXPECT_FALSE(load_timing_info.request_start.is_null()); 273 EXPECT_FALSE(load_timing_info.request_start.is_null());
274 274
275 ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing); 275 ExpectConnectTimingHasNoTimes(load_timing_info.connect_timing);
276 276
277 EXPECT_TRUE(load_timing_info.proxy_resolve_start.is_null()); 277 EXPECT_TRUE(load_timing_info.proxy_resolve_start.is_null());
278 EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null()); 278 EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null());
279 EXPECT_TRUE(load_timing_info.send_start.is_null()); 279 EXPECT_TRUE(load_timing_info.send_start.is_null());
(...skipping 9931 matching lines...) Expand 10 before | Expand all | Expand 10 after
10211 AddTestInterceptor()->set_main_intercept_job(std::move(job)); 10211 AddTestInterceptor()->set_main_intercept_job(std::move(job));
10212 10212
10213 req->Start(); 10213 req->Start();
10214 req->Cancel(); 10214 req->Cancel();
10215 base::RunLoop().RunUntilIdle(); 10215 base::RunLoop().RunUntilIdle();
10216 EXPECT_EQ(ERR_ABORTED, d.request_status()); 10216 EXPECT_EQ(ERR_ABORTED, d.request_status());
10217 EXPECT_EQ(0, d.received_redirect_count()); 10217 EXPECT_EQ(0, d.received_redirect_count());
10218 } 10218 }
10219 10219
10220 } // namespace net 10220 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698