content/browser/resolve_proxy_msg_helper.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/resolve_proxy_msg_helper.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc ('k') | content/browser/service_worker/service_worker_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/resolve_proxy_msg_helper.h"	5 #include "content/browser/resolve_proxy_msg_helper.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/bind_helpers.h"	8 #include "base/bind_helpers.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "content/common/view_messages.h"	10 #include "content/common/view_messages.h"

11 #include "net/base/net_errors.h"	11 #include "net/base/net_errors.h"

	12 #include "net/log/net_log_with_source.h"

12 #include "net/url_request/url_request_context.h"	13 #include "net/url_request/url_request_context.h"

13 #include "net/url_request/url_request_context_getter.h"	14 #include "net/url_request/url_request_context_getter.h"

14	15

15 namespace content {	16 namespace content {

16	17

17 ResolveProxyMsgHelper::ResolveProxyMsgHelper(	18 ResolveProxyMsgHelper::ResolveProxyMsgHelper(

18 net::URLRequestContextGetter* getter)	19 net::URLRequestContextGetter* getter)

19 : BrowserMessageFilter(ViewMsgStart),	20 : BrowserMessageFilter(ViewMsgStart),

20 context_getter_(getter),	21 context_getter_(getter),

21 proxy_service_(NULL) {	22 proxy_service_(NULL) {

(...skipping 73 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
95 base::Bind(&ResolveProxyMsgHelper::OnResolveProxyCompleted,	96 base::Bind(&ResolveProxyMsgHelper::OnResolveProxyCompleted,

96 base::Unretained(this)),	97 base::Unretained(this)),

97 &req.pac_req, NULL, net::NetLogWithSource());	98 &req.pac_req, NULL, net::NetLogWithSource());

98	99

99 // Completed synchronously.	100 // Completed synchronously.

100 if (result != net::ERR_IO_PENDING)	101 if (result != net::ERR_IO_PENDING)

101 OnResolveProxyCompleted(result);	102 OnResolveProxyCompleted(result);

102 }	103 }

103	104

104 } // namespace content	105 } // namespace content

OLD	NEW