chrome/browser/devtools/device/port_forwarding_controller.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/devtools/device/port_forwarding_controller.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/devtools/device/adb/mock_adb_server.cc ('k') | chrome/browser/devtools/device/port_forwarding_controller.cc » ('j') | chrome/browser/extensions/api/log_private/log_private_api.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_PORT_FORWARDING_CONTROLLER_H_	5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_PORT_FORWARDING_CONTROLLER_H_

6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_PORT_FORWARDING_CONTROLLER_H_	6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_PORT_FORWARDING_CONTROLLER_H_

7	7

8 #include <map>	8 #include <map>

	9 #include <string>

9	10

10 #include "base/macros.h"	11 #include "base/macros.h"

11 #include "chrome/browser/devtools/device/devtools_android_bridge.h"	12 #include "chrome/browser/devtools/device/devtools_android_bridge.h"

12 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"	13 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"

13 #include "components/keyed_service/core/keyed_service.h"	14 #include "components/keyed_service/core/keyed_service.h"

14 #include "components/prefs/pref_change_registrar.h"	15 #include "components/prefs/pref_change_registrar.h"

15	16

16 class PrefService;	17 class PrefService;

17 class Profile;	18 class Profile;

18	19

(...skipping 24 matching lines...) Expand all Loading...
43 PrefChangeRegistrar pref_change_registrar_;	44 PrefChangeRegistrar pref_change_registrar_;

44 Registry registry_;	45 Registry registry_;

45	46

46 typedef std::map<int, std::string> ForwardingMap;	47 typedef std::map<int, std::string> ForwardingMap;

47 ForwardingMap forwarding_map_;	48 ForwardingMap forwarding_map_;

48	49

49 DISALLOW_COPY_AND_ASSIGN(PortForwardingController);	50 DISALLOW_COPY_AND_ASSIGN(PortForwardingController);

50 };	51 };

51	52

52 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_PORT_FORWARDING_CONTROLLER_H_	53 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_PORT_FORWARDING_CONTROLLER_H_

OLD	NEW