chrome/browser/devtools/device/adb/adb_client_socket.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/devtools/device/adb/adb_client_socket.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc ('k') | chrome/browser/devtools/device/adb/adb_client_socket.cc » ('j') | chrome/browser/extensions/api/log_private/log_private_api.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_ADB_ADB_CLIENT_SOCKET_H_	5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_ADB_ADB_CLIENT_SOCKET_H_

6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_ADB_ADB_CLIENT_SOCKET_H_	6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_ADB_ADB_CLIENT_SOCKET_H_

7	7

	8 #include <string>

	9

8 #include "base/callback.h"	10 #include "base/callback.h"

9 #include "base/macros.h"	11 #include "base/macros.h"

10 #include "net/base/io_buffer.h"	12 #include "net/base/io_buffer.h"

11 #include "net/socket/stream_socket.h"	13 #include "net/socket/stream_socket.h"

12	14

13 class AdbClientSocket {	15 class AdbClientSocket {

14 public:	16 public:

15 typedef base::Callback<void(int, const std::string&)> CommandCallback;	17 typedef base::Callback<void(int, const std::string&)> CommandCallback;

16 typedef base::Callback<void(int result, std::unique_ptr<net::StreamSocket>)>	18 typedef base::Callback<void(int result, std::unique_ptr<net::StreamSocket>)>

17 SocketCallback;	19 SocketCallback;

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 int bytes_left,	54 int bytes_left,

53 int result);	55 int result);

54	56

55 std::string host_;	57 std::string host_;

56 int port_;	58 int port_;

57	59

58 DISALLOW_COPY_AND_ASSIGN(AdbClientSocket);	60 DISALLOW_COPY_AND_ASSIGN(AdbClientSocket);

59 };	61 };

60	62

61 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_ADB_ADB_CLIENT_SOCKET_H_	63 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_ADB_ADB_CLIENT_SOCKET_H_

OLD	NEW