Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2333923003: Change shared_sources.gni to use relative path (Closed)

Created:
4 years, 3 months ago by mikejurka
Modified:
4 years, 3 months ago
Reviewers:
abarth, brettw, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change shared_sources.gni to use relative path BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333923003 Committed: https://skia.googlesource.com/skia/+/8c24f4fae3389b9937eb73128e76226cffebdd72

Patch Set 1 #

Patch Set 2 : re-add SkDebug_stdio for Fuchsia builds #

Patch Set 3 : fix fuchsia build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mikejurka
4 years, 3 months ago (2016-09-12 23:21:03 UTC) #4
mtklein_C
lgtm
4 years, 3 months ago (2016-09-12 23:24:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333923003/1
4 years, 3 months ago (2016-09-12 23:24:19 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 23:52:01 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8c24f4fae3389b9937eb73128e76226cffebdd72

Powered by Google App Engine
This is Rietveld 408576698