Discount for inactivity timeout for recording session length

Discount for inactivity timeout for recording session length

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
Committed: https://crrev.com/1d1e6805b10cf2101d4a926a4c9c19ffb9c66749
Cr-Commit-Position: refs/heads/master@{#418396}

[gayane -on leave until 09-2017, 2016-09-12 21:25:35]

The CQ bit was checked by gayane@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:25:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:00:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:00:18]

Dry run: This issue passed the CQ dry run.

[gayane -on leave until 09-2017, 2016-09-13 17:47:52]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org

[gayane -on leave until 09-2017, 2016-09-13 17:47:52]

I have changed the unit test to be a bit more flexible. Didn't find good
solution for guaranteeing it not be flaky. 
What do you think ?

[Alexei Svitkine (slow), 2016-09-13 17:49:38]

Can you make patch set 1 be the original thing you landed and a second patch set
to contain the difference since then? This way, it's easy to review what
changed. Thanks!

[gayane -on leave until 09-2017, 2016-09-13 18:09:05]

Patchset #1 (id:1) has been deleted

[gayane -on leave until 09-2017, 2016-09-13 18:13:53]

Separated reverted changes from the new changes.

https://codereview.chromium.org/2333923002/diff/20001/chrome/browser/metrics/...
File
chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc
(right):

https://codereview.chromium.org/2333923002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/desktop_engagement/desktop_engagement_service_unittest.cc:171:
histogram_tester.ExpectUniqueSample("Session.TotalDuration", 0, 1);
this check appeared to be flaky and I assumed that maybe sometimes the session
length jumps from 0 to 1.

[Alexei Svitkine (slow), 2016-09-13 19:25:00]

Thanks! We discussed offline, let me know when it's ready to take another look.

[gayane -on leave until 09-2017, 2016-09-13 21:04:31]

PTAL

[Alexei Svitkine (slow), 2016-09-13 21:21:35]

lgtm

[gayane -on leave until 09-2017, 2016-09-13 21:29:09]

The CQ bit was checked by gayane@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:48:55]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2016-09-13 22:50:34]

Description was changed from

==========
Discount for inactivity timeout for recording session length

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
==========

to

==========
Discount for inactivity timeout for recording session length

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538

Committed: https://crrev.com/1d1e6805b10cf2101d4a926a4c9c19ffb9c66749
Cr-Commit-Position: refs/heads/master@{#418396}
==========

[commit-bot: I haz the power, 2016-09-13 22:50:35]

Patchset 3 (id:??) landed as
https://crrev.com/1d1e6805b10cf2101d4a926a4c9c19ffb9c66749
Cr-Commit-Position: refs/heads/master@{#418396}