Alternate approach to turn on freetype in Fuchsia.

Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

We (obviously?) don't have Fuchsia builders, so I've got to rely on you for sanity testing this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002

Committed: https://skia.googlesource.com/skia/+/cdedd0e061f3f50cd217638c28b27d798d930896

[mtklein_C, 2016-09-12 21:20:36]

Description was changed from

==========
Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

BUG=skia:
==========

to

==========
Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002
==========

[mtklein_C, 2016-09-12 21:20:39]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:20:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-12 21:25:06]

Description was changed from

==========
Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002
==========

to

==========
Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

We (obviously?) don't have Fuchsia builders, so I've got to rely on you for
sanity testing this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002
==========

[mtklein_C, 2016-09-12 21:25:22]

mtklein@chromium.org changed reviewers:
+ abarth@google.com, mikejurka@google.com

[mtklein_C, 2016-09-12 21:26:14]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-09-12 21:27:16]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:27:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-12 21:28:13]

Whoops, sorry, PS 2 now features the _empty_factory.cpp you used originally.

[abarth, 2016-09-12 22:02:57]

LGTM

This won't build as-written because we spell freetype slightly differently, but
we can tweak our BUILD.gn files to make this work.  (Your spelling of freetype
is prettier than ours.)

[mtklein_C, 2016-09-12 22:12:59]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-09-12 22:13:00]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-09-12 22:13:09]

On 2016/09/12 at 22:02:57, abarth wrote:
> LGTM
> 
> This won't build as-written because we spell freetype slightly differently,
but we can tweak our BUILD.gn files to make this work.  (Your spelling of
freetype is prettier than ours.)

sgtm.

[commit-bot: I haz the power, 2016-09-12 22:13:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:15:45]

Description was changed from

==========
Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

We (obviously?) don't have Fuchsia builders, so I've got to rely on you for
sanity testing this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002
==========

to

==========
Alternate approach to turn on freetype in Fuchsia.

What do you think of this?  It's basically what you wrote, factored differently.

Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files
via the :typeface_freetype target.

Then we just pull out the SkFontMgr Fuchsia wants to use into its own little
:fontmgr_fuchsia target.  No major difference here, except the availability
of freetype headers, etc, is a bit more tightly scoped to just those that
need them.

We (obviously?) don't have Fuchsia builders, so I've got to rely on you for
sanity testing this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002

Committed:
https://skia.googlesource.com/skia/+/cdedd0e061f3f50cd217638c28b27d798d930896
==========

[commit-bot: I haz the power, 2016-09-12 22:15:46]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cdedd0e061f3f50cd217638c28b27d798d930896