Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2333913002: Alternate approach to turn on freetype in Fuchsia. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
abarth, mikejurka
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Alternate approach to turn on freetype in Fuchsia. What do you think of this? It's basically what you wrote, factored differently. Flipping on skia_use_freetype will enable the SkFontHost_Freetype*.cpp files via the :typeface_freetype target. Then we just pull out the SkFontMgr Fuchsia wants to use into its own little :fontmgr_fuchsia target. No major difference here, except the availability of freetype headers, etc, is a bit more tightly scoped to just those that need them. We (obviously?) don't have Fuchsia builders, so I've got to rely on you for sanity testing this. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333913002 Committed: https://skia.googlesource.com/skia/+/cdedd0e061f3f50cd217638c28b27d798d930896

Patch Set 1 #

Patch Set 2 : Correct factory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M BUILD.gn View 1 4 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
mtklein_C
4 years, 3 months ago (2016-09-12 21:25:22 UTC) #6
mtklein_C
Whoops, sorry, PS 2 now features the _empty_factory.cpp you used originally.
4 years, 3 months ago (2016-09-12 21:28:13 UTC) #10
abarth
LGTM This won't build as-written because we spell freetype slightly differently, but we can tweak ...
4 years, 3 months ago (2016-09-12 22:02:57 UTC) #11
mtklein_C
On 2016/09/12 at 22:02:57, abarth wrote: > LGTM > > This won't build as-written because ...
4 years, 3 months ago (2016-09-12 22:13:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333913002/20001
4 years, 3 months ago (2016-09-12 22:13:11 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 22:15:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cdedd0e061f3f50cd217638c28b27d798d930896

Powered by Google App Engine
This is Rietveld 408576698