Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2333893002: Fix a bug that causes a DCHECK to sometimes get it for no good reason. (Closed)

Created:
4 years, 3 months ago by michaeln
Modified:
4 years, 3 months ago
Reviewers:
cmumford
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that causes a DCHECK to sometimes get hit for no good reason. BUG=584574 Committed: https://crrev.com/0beb0eb64f739808a55933776facf5ea68d2bfbf Cr-Commit-Position: refs/heads/master@{#418740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/appcache/appcache_request_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
michaeln
ptal
4 years, 3 months ago (2016-09-12 21:28:56 UTC) #5
michaeln
friendly ping
4 years, 3 months ago (2016-09-14 20:25:44 UTC) #8
cmumford
lgtm
4 years, 3 months ago (2016-09-14 20:34:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333893002/1
4 years, 3 months ago (2016-09-14 20:41:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/279857)
4 years, 3 months ago (2016-09-14 21:30:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333893002/1
4 years, 3 months ago (2016-09-15 00:33:38 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 01:14:46 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:18:12 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0beb0eb64f739808a55933776facf5ea68d2bfbf
Cr-Commit-Position: refs/heads/master@{#418740}

Powered by Google App Engine
This is Rietveld 408576698