Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: pkg/analyzer/lib/src/dart/resolver/scope.dart

Issue 2333873002: Tweaks for Scope comments. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/resolver/scope.dart
diff --git a/pkg/analyzer/lib/src/dart/resolver/scope.dart b/pkg/analyzer/lib/src/dart/resolver/scope.dart
index e3f02b08ab85e5e11b651ce6d7b7536b354fb6d7..e5549470f53a933dfcb76ccd335b90654b1a4f94 100644
--- a/pkg/analyzer/lib/src/dart/resolver/scope.dart
+++ b/pkg/analyzer/lib/src/dart/resolver/scope.dart
@@ -20,7 +20,7 @@ import 'package:analyzer/src/generated/source.dart';
class BlockScope extends EnclosedScope {
/**
* Initialize a newly created scope, enclosed within the [enclosingScope],
- * based on the given [classElement].
+ * based on the given [block].
*/
BlockScope(Scope enclosingScope, Block block) : super(enclosingScope) {
if (block == null) {
@@ -397,8 +397,7 @@ class LibraryImportScope extends Scope {
/**
* Initialize a newly created scope representing the names imported into the
- * [_definingLibrary]. The error listener is no longer used and should be
- * omitted.
+ * [_definingLibrary].
*/
LibraryImportScope(this._definingLibrary) {
_createImportedNamespaces();
@@ -582,8 +581,7 @@ class LibraryImportScope extends Scope {
class LibraryScope extends EnclosedScope {
/**
* Initialize a newly created scope representing the names defined in the
- * [definingLibrary]. The error listener is no longer used and should be
- * omitted.
+ * [definingLibrary].
*/
LibraryScope(LibraryElement definingLibrary)
: super(new LibraryImportScope(definingLibrary)) {
@@ -1003,10 +1001,8 @@ abstract class Scope {
/**
* Add the given [element] to this scope. If there is already an element with
- * the given name defined in this scope, then an error will be generated and
- * the original element will continue to be mapped to the name. If there is an
- * element with the given name in an enclosing scope, then a warning will be
- * generated but the given element will hide the inherited element.
+ * the given name defined in this scope, then the original element will
+ * continue to be mapped to the name.
*/
void define(Element element) {
String name = _getName(element);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698