Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: net/quic/chromium/quic_http_stream.cc

Issue 2333863003: Revert of Implement QuicHttpStream::GetLoadTimingInfo (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_http_stream.h ('k') | net/quic/chromium/quic_http_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_http_stream.cc
diff --git a/net/quic/chromium/quic_http_stream.cc b/net/quic/chromium/quic_http_stream.cc
index dfafa674d2c4356a7a677f2d2c904aab272a4e50..9ec364ce0833da527ac00ce86cea55bbf0ba219a 100644
--- a/net/quic/chromium/quic_http_stream.cc
+++ b/net/quic/chromium/quic_http_stream.cc
@@ -58,7 +58,6 @@
headers_bytes_sent_(0),
closed_stream_received_bytes_(0),
closed_stream_sent_bytes_(0),
- closed_is_first_stream_(false),
user_buffer_len_(0),
quic_connection_error_(QUIC_NO_ERROR),
port_migration_detected_(false),
@@ -417,15 +416,7 @@
}
bool QuicHttpStream::GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const {
- bool is_first_stream = closed_is_first_stream_;
- if (stream_)
- is_first_stream = stream_->IsFirstStream();
- if (is_first_stream) {
- load_timing_info->socket_reused = false;
- load_timing_info->connect_timing = connect_timing_;
- } else {
- load_timing_info->socket_reused = true;
- }
+ // TODO(mmenke): Figure out what to do here.
return true;
}
@@ -650,7 +641,6 @@
return was_handshake_confirmed_ ? ERR_CONNECTION_CLOSED
: ERR_QUIC_HANDSHAKE_FAILED;
}
- connect_timing_ = session_->GetConnectTiming();
int rv = stream_request_.StartRequest(
session_, &stream_,
base::Bind(&QuicHttpStream::OnStreamReady, weak_factory_.GetWeakPtr()));
@@ -844,7 +834,6 @@
return;
closed_stream_received_bytes_ = stream_->stream_bytes_read();
closed_stream_sent_bytes_ = stream_->stream_bytes_written();
- closed_is_first_stream_ = stream_->IsFirstStream();
stream_ = nullptr;
// If |request_body_stream_| is non-NULL, Reset it, to abort any in progress
« no previous file with comments | « net/quic/chromium/quic_http_stream.h ('k') | net/quic/chromium/quic_http_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698