Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2333863002: Bring inspector_protocol.gypi back (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
brettw, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bring inspector_protocol.gypi back This file is used by V8's gyp. It will be moved out from platform/ soon. R=brettw@chromium.org,dgozman@chromium.org Committed: https://crrev.com/8430bd332b7f8c625a1ea971dcb9b6b79c0fbc38 Cr-Commit-Position: refs/heads/master@{#418699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gypi View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kozy
Please take a look. It was removed by https://codereview.chromium.org/2323393004/.
4 years, 3 months ago (2016-09-12 20:47:24 UTC) #1
dgozman
lgtm
4 years, 3 months ago (2016-09-12 20:50:39 UTC) #4
brettw
lgtm
4 years, 3 months ago (2016-09-14 19:38:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333863002/1
4 years, 3 months ago (2016-09-14 19:42:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297745)
4 years, 3 months ago (2016-09-14 20:41:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333863002/1
4 years, 3 months ago (2016-09-14 21:24:17 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 22:34:29 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 22:38:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8430bd332b7f8c625a1ea971dcb9b6b79c0fbc38
Cr-Commit-Position: refs/heads/master@{#418699}

Powered by Google App Engine
This is Rietveld 408576698