Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 233383002: Add a new bench that tests a simple image filter DAG. (Closed)

Created:
6 years, 8 months ago by Stephen White
Modified:
6 years, 8 months ago
Reviewers:
Justin Novosad
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a new bench that tests a simple image filter DAG. This bench exercises a blur filter connected to 5 inputs of the same merge filter. R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=14135

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Patch Set 3 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A bench/ImageFilterDAGBench.cpp View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
reed@: PTAL. Thanks!
6 years, 8 months ago (2014-04-10 15:24:36 UTC) #1
Stephen White
Never mind; I'll bug junov@ instead since this doesn't have any API changes. junov@: PTAL. ...
6 years, 8 months ago (2014-04-10 15:37:21 UTC) #2
Justin Novosad
lgtm with nits. I get what is being tested here because we talked about it ...
6 years, 8 months ago (2014-04-10 15:51:28 UTC) #3
Stephen White
https://codereview.chromium.org/233383002/diff/1/bench/ImageFilterDAGBench.cpp File bench/ImageFilterDAGBench.cpp (right): https://codereview.chromium.org/233383002/diff/1/bench/ImageFilterDAGBench.cpp#newcode13 bench/ImageFilterDAGBench.cpp:13: #define NUM_COPIES 5 On 2014/04/10 15:51:28, junov wrote: > ...
6 years, 8 months ago (2014-04-10 16:13:44 UTC) #4
Stephen White
6 years, 8 months ago (2014-04-10 16:16:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r14135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698