Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2333813002: Introduce WebInputMethodController to blink (Closed)
Patch Set: Moved ConfirmCompositionBehavior to WebInputMethodController Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index a69995d7d3a426ca11657f123a8234d91eab26c1..67ba74394e239c93f07a4e92aeeb848db66d9b0e 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -85,6 +85,7 @@ class UserGestureToken;
class WebActiveGestureAnimation;
class WebDevToolsAgentImpl;
class WebElement;
+class WebInputMethodControllerImpl;
class WebLayerTreeView;
class WebLocalFrame;
class WebLocalFrameImpl;
@@ -136,13 +137,6 @@ public:
float topControlsShownRatioDelta) override;
void mouseCaptureLost() override;
void setFocus(bool enable) override;
- bool setComposition(
- const WebString& text,
- const WebVector<WebCompositionUnderline>& underlines,
- int selectionStart,
- int selectionEnd) override;
- bool commitText(const WebString& text, int relativeCaretPosition) override;
- bool finishComposingText(ConfirmCompositionBehavior selectionBehavior) override;
WebRange compositionRange() override;
WebTextInputInfo textInputInfo() override;
WebTextInputType textInputType() override;
@@ -518,6 +512,11 @@ public:
ChromeClientImpl& chromeClient() const { return *m_chromeClientImpl.get(); }
+ // Returns the currently active WebInputMethodController which the one
+ // corresponding to the focused frame. It will return nullptr if there are
+ // none or |m_imeAcceptEvents| is false.
+ WebInputMethodControllerImpl* getActiveWebInputMethodController() const;
lfg 2016/09/16 20:17:09 Can you make this private? We should only be getti
EhsanK 2016/09/20 15:38:29 Acknowledged.
+
private:
InspectorOverlay* inspectorOverlay();

Powered by Google App Engine
This is Rietveld 408576698