Introduce WebInputMethodController to blink

third_party/WebKit/Source/web/WebViewImpl.h

Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index a69995d7d3a426ca11657f123a8234d91eab26c1..bc3ccc9f5fd69be8b7628d0dad0b0a0fd13e9684 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -85,6 +85,7 @@ class UserGestureToken;
 class WebActiveGestureAnimation;
 class WebDevToolsAgentImpl;
 class WebElement;
+class WebInputMethodControllerImpl;
 class WebLayerTreeView;
 class WebLocalFrame;
 class WebLocalFrameImpl;
@@ -518,6 +519,11 @@ public:
 
     ChromeClientImpl& chromeClient() const { return *m_chromeClientImpl.get(); }
 
+    // Returns the currently active WebInputMethodController which the one
+    // corresponding to the focused frame. It will return nullptr if there are
+    // none or |m_imeAcceptEvents| is false.
+    WebInputMethodControllerImpl* getActiveWebInputMethodController() const;

[lfg, 2016/09/14 19:20:26]

Why didn't you implement this in WebFrameWidgetBase? This doesn't need to be
duplicated between WebViewImpl and WebFrameWidgetImpl.

It also means that setComposition, commitText and finishCompositingText also
don't have to be duplicated.

[EhsanK, 2016/09/16 15:06:28]

This returns WebInputMethodController which is public and should be accessible
publicly so that RenderWidget or other users of blink can call IME methods on
the focused frame.
Those actually should be removed from Web*Widget. and WebView. They now live in
this new class. I did not remove them to avoid making the CL at this stage big.
Following our offline conversation I will add that change in the upcoming patch.

[lfg, 2016/09/16 15:11:30]

WebFrameWidgetBase inherits from WebWidget, just override the methods there.
That's right, let's do this now. Override the virtuals in WebFrameWidgetBase and
implement them there. Then remove the implementations from WebViewImpl and
WebFrameWidgetImpl.

+
 private:
     InspectorOverlay* inspectorOverlay();