Cleanup: remove WebCryptoResultPrivate from blink API.

Cleanup: remove WebCryptoResultPrivate from blink API.

The interface had originally been exposed for chromium-side unit-tests, but jamesr suggests using a different approach.

This change also moves CryptoResult to a standalone file.

BUG=245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156810

[eroman, 2013-08-23 23:51:26]

https://codereview.chromium.org/23338006/diff/1/Source/modules/crypto/CryptoR...
File Source/modules/crypto/CryptoResult.h (right):

https://codereview.chromium.org/23338006/diff/1/Source/modules/crypto/CryptoR...
Source/modules/crypto/CryptoResult.h:44: class CryptoResult : public
ThreadSafeRefCounted<CryptoResult> {
This class is unchanged except for adding a destructor. (Just moving it out of
SubtleCrypto.cpp)

[jamesr, 2013-08-24 02:02:26]

core/ and public/ lgtm (I have no powers for modules but that looks fine too).
Thanks for cleaning this up.

https://codereview.chromium.org/23338006/diff/1/public/platform/WebCrypto.h
File public/platform/WebCrypto.h (right):

https://codereview.chromium.org/23338006/diff/1/public/platform/WebCrypto.h#n...
public/platform/WebCrypto.h:48: explicit WebCryptoResult(WebCore::CryptoResult*
impl) : m_impl(impl) { }
nit: this is slightly more commonly done with PassRefPtr<> and an out-of-line
c'tor.  See for instance
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....
you should probably also move this down to be lower in the header since someone
trying to understand how to use this interface probably isn't as interested in
the implementation details

[eroman, 2013-08-27 19:00:06]

https://codereview.chromium.org/23338006/diff/1/public/platform/WebCrypto.h
File public/platform/WebCrypto.h (right):

https://codereview.chromium.org/23338006/diff/1/public/platform/WebCrypto.h#n...
public/platform/WebCrypto.h:48: explicit WebCryptoResult(WebCore::CryptoResult*
impl) : m_impl(impl) { }
On 2013/08/24 02:02:26, jamesr wrote:
> nit: this is slightly more commonly done with PassRefPtr<> and an out-of-line
> c'tor.  See for instance
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....
> you should probably also move this down to be lower in the header since
someone
> trying to understand how to use this interface probably isn't as interested in
> the implementation details

Done.

[abarth-chromium, 2013-08-28 00:07:42]

lgtm

[commit-bot: I haz the power, 2013-08-28 00:07:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/23338006/18001

[commit-bot: I haz the power, 2013-08-28 03:18:28]

Change committed as 156810