Mac InfoBar: Use cross platform infobar classes

Mac InfoBar: Use cross platform infobar classes

Currently the Mac code has a dummy InfoBar implementation that it unused.
This code replaces that with the cross platform implementation.

Using the cross platform implementation means:
  - animation is now driven by the cross platform code
  - layout is now controlled by InfoBarContainer
  - InfoBarDelegate is now owned by InfoBar

BUG=62154
TEST=
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219956

[Peter Kasting, 2013-08-24 03:00:17]

One offhand note (don't have time to review tonight): InfoBarDelegate shouldn't
be owned by InfoBar yet (not until after my ownership model change), unless
you're doing something very different than the other platforms.  Be careful
here.

Also would like to see trybot results of this.

[Peter Kasting, 2013-08-24 03:03:39]

https://codereview.chromium.org/23338005/diff/1/chrome/browser/infobars/infob...
File chrome/browser/infobars/infobar.h (right):

https://codereview.chromium.org/23338005/diff/1/chrome/browser/infobars/infob...
chrome/browser/infobars/infobar.h:69: void RemoveSelf();
One other note.  Any way to avoid making these functions public?  I'm not as
worried about SetBarTargetHeight(), but I'd rather not make RemoveSelf() and
owner() public if possible.  Normally only an InfoBar itself should be calling
these, and especially RemoveSelf() is dangerous and somewhat confusing (people
really should be calling CloseSoon() instead in most cases).

[sail, 2013-08-24 20:54:32]

On 2013/08/24 03:00:17, Peter Kasting wrote:
> One offhand note (don't have time to review tonight): InfoBarDelegate
shouldn't
> be owned by InfoBar yet (not until after my ownership model change), unless
> you're doing something very different than the other platforms.  Be careful
> here.

I thought InfoBar already owned InfoBarDelegate. See:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/inf...

> 
> Also would like to see trybot results of this.

Will do.

[sail, 2013-08-25 18:31:07]

https://codereview.chromium.org/23338005/diff/1/chrome/browser/infobars/infob...
File chrome/browser/infobars/infobar.h (right):

https://codereview.chromium.org/23338005/diff/1/chrome/browser/infobars/infob...
chrome/browser/infobars/infobar.h:69: void RemoveSelf();
On 2013/08/24 03:03:39, Peter Kasting wrote:
> One other note.  Any way to avoid making these functions public?  I'm not as
> worried about SetBarTargetHeight(), but I'd rather not make RemoveSelf() and
> owner() public if possible.  Normally only an InfoBar itself should be calling
> these, and especially RemoveSelf() is dangerous and somewhat confusing (people
> really should be calling CloseSoon() instead in most cases).

Done.

I needed these to be public so that the Objective-C classes could access them. I
moved RemoveSelf and owner() into InfoBarCocoa.

[Robert Sesek, 2013-08-26 14:06:55]

Seems pretty clean - nice!

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_controller.h:501: - (void)layoutInfoBar;
Document

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_controller.h:501: - (void)layoutInfoBar;
This lays out infoBars does't it?

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
(right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm:61:
scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(owner, this));
Why keep this in a scoped_ptr<> if you're just going to release it?

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm
(right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm:59: 
nit: double blank line

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_cocoa.h (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_cocoa.h:5: #ifndef
CHROME_BROWSER_UI_COCOA_INFOBARS_INFOBAR_COCOA_H_
Needs documentation.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.h (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:18: class
InfoBarContainerCocoa;
nit: sort

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:27: @protocol
InfoBarContainerControllerBase
"Base" implies an inheritance relationship. Can you think of a better name?

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:57: BOOL
oldOverlappingTipHeight_;
What's this for (i.e. document)?

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:20: @interface
InfoBarContainerController()
nit: space before (

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:34: if ((self =
[super init])) {
Don't you need to call through -initWithNibName:bundle: because it's the
designated initializer?

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:49:
containerCocoa_.reset();
Why does this need to be done explicitly?

[sail, 2013-08-26 18:32:23]

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_controller.h:501: - (void)layoutInfoBar;
On 2013/08/26 14:06:56, rsesek wrote:
> This lays out infoBars does't it?

Done.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
(right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm:61:
scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(owner, this));
On 2013/08/26 14:06:56, rsesek wrote:
> Why keep this in a scoped_ptr<> if you're just going to release it?

I really like avoiding raw pointers. Similar to using scoped_nsobject and doing
.autorelease at the end.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm
(right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm:59: 
On 2013/08/26 14:06:56, rsesek wrote:
> nit: double blank line

Done.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_cocoa.h (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_cocoa.h:5: #ifndef
CHROME_BROWSER_UI_COCOA_INFOBARS_INFOBAR_COCOA_H_
On 2013/08/26 14:06:56, rsesek wrote:
> Needs documentation.

Done.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.h (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:18: class
InfoBarContainerCocoa;
On 2013/08/26 14:06:56, rsesek wrote:
> nit: sort

Done.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:27: @protocol
InfoBarContainerControllerBase
On 2013/08/26 14:06:56, rsesek wrote:
> "Base" implies an inheritance relationship. Can you think of a better name?

What do you think of InfoBarContainerControllerProtocol?

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:57: BOOL
oldOverlappingTipHeight_;
On 2013/08/26 14:06:56, rsesek wrote:
> What's this for (i.e. document)?

Done.
(Also, big oops here. That should be a int not a BOOL.)

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (right):

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:20: @interface
InfoBarContainerController()
On 2013/08/26 14:06:56, rsesek wrote:
> nit: space before (

Done.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:34: if ((self =
[super init])) {
On 2013/08/26 14:06:56, rsesek wrote:
> Don't you need to call through -initWithNibName:bundle: because it's the
> designated initializer?

Done.

https://codereview.chromium.org/23338005/diff/24001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm:49:
containerCocoa_.reset();
On 2013/08/26 14:06:56, rsesek wrote:
> Why does this need to be done explicitly?

Done.
Documented.

[Peter Kasting, 2013-08-26 18:38:04]

On 2013/08/24 20:54:32, sail wrote:
> On 2013/08/24 03:00:17, Peter Kasting wrote:
> > One offhand note (don't have time to review tonight): InfoBarDelegate
> shouldn't
> > be owned by InfoBar yet (not until after my ownership model change), unless
> > you're doing something very different than the other platforms.  Be careful
> > here.
> 
> I thought InfoBar already owned InfoBarDelegate. See:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/inf...

InfoBar is responsible for deleting InfoBarDelegate at the moment, but it
doesn't own it in the sense I think of ownership.

(1) InfoBar's lifespan is currently much shorter than InfoBarDelegate, and there
may be a series of several InfoBars associated with the delegate.
(2) InfoBarService knows about InfoBarDelegates directly, and not InfoBars; in
some sense, InfoBarService is the class that "owns" the InfoBarDelegate by
receiving it on first creation and deciding when it should die, and InfoBar is
just the class that it uses to fire the delete message.

It's kind of a semantic game, though.  I suppose even after my refactor one
could think of InfoBarDelegates as owning themselves rather than being owned by
InfoBar, but whatever.  :)

[Peter Kasting, 2013-08-26 18:51:24]

So why have a lightweight InfoBarCocoa wrapper class around InfoBarController,
instead of just making InfoBarCocoa itself be the heavyweight object?  Is this
because an ObjC class cannot be a subclass of a C++ class?

[Robert Sesek, 2013-08-26 18:52:17]

On 2013/08/26 18:51:24, Peter Kasting wrote:
> So why have a lightweight InfoBarCocoa wrapper class around InfoBarController,
> instead of just making InfoBarCocoa itself be the heavyweight object?  Is this
> because an ObjC class cannot be a subclass of a C++ class?

Yes. The inheritance is completely separate. And ObjC can't be a friend of C++.

[Peter Kasting, 2013-08-26 19:05:12]

On 2013/08/26 18:52:17, rsesek wrote:
> On 2013/08/26 18:51:24, Peter Kasting wrote:
> > So why have a lightweight InfoBarCocoa wrapper class around
InfoBarController,
> > instead of just making InfoBarCocoa itself be the heavyweight object?  Is
this
> > because an ObjC class cannot be a subclass of a C++ class?
> 
> Yes. The inheritance is completely separate. And ObjC can't be a friend of
C++.

Sad, but what can you do.  I suspect this implementation will look similar to
the Android implementation, then (since they need to use Java classes to do the
ultimate interfacing with the rest of their UI layer).  Of course Android is not
yet fully converted to the cross-platform worldview and upstreamed.

LGTM for the trivial changes in non-Mac code, though you may want to coordinate
with iOS folks to ensure you don't break them unexpectedly with the ifdef
removal.  (I have no idea if this would impact them at all, just being
cautious.)

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/infobars/i...
File chrome/browser/infobars/infobar.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/infobars/i...
chrome/browser/infobars/infobar.h:68: void SetBarTargetHeight(int height);
Nit: Please also move the implementation in the .cc file to stay in the same
relative order as in this .h file.

[Robert Sesek, 2013-08-26 19:35:02]

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_controller.h:502: - (void)layoutInfoBar;
naming: layoutInfoBarS?

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
(right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm:61:
scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(owner, this));
Shouldn't this be info_bar? And the files too, since the classes are capitalized
as InfoBar? Not sure it makes sense to change here because of the other
inconsistencies, but I thought I'd call it out…

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm
(right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm:87:
virtual void SetUp() {
OVERRIDE

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm:111:
virtual void TearDown() {
OVERRIDE

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h:17:
InfoBarContainerCocoa(InfoBarContainerController* controller);
explicit

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm:21: size_t position)
{
nit: align

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:50:
scoped_ptr<InfoBarContainerCocoa> containerCocoa_;
nit: document this, too?

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm
(right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm:22:
virtual void SetUp() {
OVERRIDE

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm:36:
virtual void TearDown() {
OVERRIDE

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm:38:
[controller_ release];
Keep this in a scoper?

[Peter Kasting, 2013-08-26 19:38:43]

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm
(right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm:61:
scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(owner, this));
On 2013/08/26 19:35:02, rsesek wrote:
> Shouldn't this be info_bar? And the files too, since the classes are
capitalized
> as InfoBar? Not sure it makes sense to change here because of the other
> inconsistencies, but I thought I'd call it out…

It is a fair point.  The rest of the infobar code is very consistent about using
"infobar" instead of "info_bar" (I've had to fix some exceptions), so I'd rather
see "infobar" used here -- but I definitely think it would be nice to someday
rename all the relevant classes "Infobar" instead of "InfoBar" to match.

[sail, 2013-08-26 21:58:43]

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_controller.h:502: - (void)layoutInfoBar;
On 2013/08/26 19:35:02, rsesek wrote:
> naming: layoutInfoBarS?

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm
(right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm:87:
virtual void SetUp() {
On 2013/08/26 19:35:02, rsesek wrote:
> OVERRIDE

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm:111:
virtual void TearDown() {
On 2013/08/26 19:35:02, rsesek wrote:
> OVERRIDE

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h:17:
InfoBarContainerCocoa(InfoBarContainerController* controller);
On 2013/08/26 19:35:02, rsesek wrote:
> explicit

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm:21: size_t position)
{
On 2013/08/26 19:35:02, rsesek wrote:
> nit: align

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller.h (right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller.h:50:
scoped_ptr<InfoBarContainerCocoa> containerCocoa_;
On 2013/08/26 19:35:02, rsesek wrote:
> nit: document this, too?

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
File chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm
(right):

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm:22:
virtual void SetUp() {
On 2013/08/26 19:35:02, rsesek wrote:
> OVERRIDE

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm:36:
virtual void TearDown() {
On 2013/08/26 19:35:02, rsesek wrote:
> OVERRIDE

Done.

https://codereview.chromium.org/23338005/diff/46001/chrome/browser/ui/cocoa/i...
chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm:38:
[controller_ release];
On 2013/08/26 19:35:02, rsesek wrote:
> Keep this in a scoper?

Done.

[Robert Sesek, 2013-08-26 22:21:47]

LGTM

https://codereview.chromium.org/23338005/diff/60001/chrome/chrome_nibs.gypi
File chrome/chrome_nibs.gypi (right):

https://codereview.chromium.org/23338005/diff/60001/chrome/chrome_nibs.gypi#n...
chrome/chrome_nibs.gypi:1: # Copyright (c) 2012 The Chromium Authors. All rights
reserved.
Anything need to be removed from chrome_nibs.gyp?

[sail, 2013-08-26 22:56:30]

https://codereview.chromium.org/23338005/diff/60001/chrome/chrome_nibs.gypi
File chrome/chrome_nibs.gypi (right):

https://codereview.chromium.org/23338005/diff/60001/chrome/chrome_nibs.gypi#n...
chrome/chrome_nibs.gypi:1: # Copyright (c) 2012 The Chromium Authors. All rights
reserved.
On 2013/08/26 22:21:48, rsesek wrote:
> Anything need to be removed from chrome_nibs.gyp?

Good catch. Removed a bunch of infobar reference that weren't needed.

[commit-bot: I haz the power, 2013-08-27 14:42:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23338005/65001

[sail, 2013-08-28 00:06:56]

TBRing thakis for *gyp* changes.

[Nico, 2013-08-28 00:08:48]

gyp *lgtm*

[commit-bot: I haz the power, 2013-08-28 00:14:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23338005/65001

[commit-bot: I haz the power, 2013-08-28 00:58:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23338005/65001

[commit-bot: I haz the power, 2013-08-28 03:00:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-28 05:12:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/23338005/65001

[commit-bot: I haz the power, 2013-08-28 07:52:46]

Change committed as 219956