Add a fuzzer test for the Clear-Site-Data header.

Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

TBR=nasko@chromium.org
BUG=607897
Committed: https://crrev.com/e56855b80edc5ef04735afedc959a629c091825e
Cr-Commit-Position: refs/heads/master@{#418334}

[msramek, 2016-09-12 14:08:53]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 14:09:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-12 14:14:58]

msramek@chromium.org changed reviewers:
+ aizatsky@chromium.org

[msramek, 2016-09-12 14:14:59]

Hello Mike,

Please have a look!

Thanks,
Martin

[commit-bot: I haz the power, 2016-09-12 15:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 15:26:39]

Dry run: This issue passed the CQ dry run.

[aizatsky, 2016-09-12 19:54:51]

https://codereview.chromium.org/2333733002/diff/1/content/test/fuzzer/clear_s...
File content/test/fuzzer/clear_site_data_fuzzer.cc (right):

https://codereview.chromium.org/2333733002/diff/1/content/test/fuzzer/clear_s...
content/test/fuzzer/clear_site_data_fuzzer.cc:27: messages_.clear();
Maybe make it local?

https://codereview.chromium.org/2333733002/diff/1/content/test/fuzzer/clear_s...
content/test/fuzzer/clear_site_data_fuzzer.cc:39: test->TestHeader(header);
I don't think a separate method is needed. I'd simply inline it here.

[msramek, 2016-09-13 14:45:15]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 14:45:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2016-09-13 14:50:06]

https://codereview.chromium.org/2333733002/diff/1/content/test/fuzzer/clear_s...
File content/test/fuzzer/clear_site_data_fuzzer.cc (right):

https://codereview.chromium.org/2333733002/diff/1/content/test/fuzzer/clear_s...
content/test/fuzzer/clear_site_data_fuzzer.cc:27: messages_.clear();
On 2016/09/12 19:54:50, aizatsky wrote:
> Maybe make it local?

Done. This was my attempt to optimize by sparing the construction and
destruction, but it's really negligible compared to ParseHeader.

https://codereview.chromium.org/2333733002/diff/1/content/test/fuzzer/clear_s...
content/test/fuzzer/clear_site_data_fuzzer.cc:39: test->TestHeader(header);
On 2016/09/12 19:54:50, aizatsky wrote:
> I don't think a separate method is needed. I'd simply inline it here.

I just noticed that I can inline |header|, so I did that.

However, I'd like to keep the class unless you feel strongly. One reason for it
was to keep local state, which - as mentioned in the previous comment - is
actually not that valuable. However, I also found it better semantically that
ClearSiteDataThrottle is a friend with 'class ClearSiteDataFuzzerTest' rather
than 'extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)'.
It's clearer for the reader why there is that frienship (because it's a *Test),
and it doesn't automatically befriend all other fuzzers.

[commit-bot: I haz the power, 2016-09-13 15:53:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 15:53:08]

Dry run: This issue passed the CQ dry run.

[aizatsky, 2016-09-13 19:10:19]

lgtm

[msramek, 2016-09-13 19:18:02]

Description was changed from

==========
Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

BUG=607897
==========

to

==========
Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

TBR=nasko@chromium.org
BUG=607897
==========

[msramek, 2016-09-13 19:18:02]

msramek@chromium.org changed reviewers:
+ nasko@chromium.org

[msramek, 2016-09-13 19:24:30]

Thanks!

Adding +Nasko as TBR for content/browser, as I'm just removing a TODO and
befriending the test class.

...and proceeding to land.

[msramek, 2016-09-13 19:24:42]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:25:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:31:22]

Description was changed from

==========
Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

TBR=nasko@chromium.org
BUG=607897
==========

to

==========
Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

TBR=nasko@chromium.org
BUG=607897
==========

[commit-bot: I haz the power, 2016-09-13 19:31:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 19:34:30]

Description was changed from

==========
Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

TBR=nasko@chromium.org
BUG=607897
==========

to

==========
Add a fuzzer test for the Clear-Site-Data header.

With a starting corpus of several valid and almost-valid entries.

TBR=nasko@chromium.org
BUG=607897

Committed: https://crrev.com/e56855b80edc5ef04735afedc959a629c091825e
Cr-Commit-Position: refs/heads/master@{#418334}
==========

[commit-bot: I haz the power, 2016-09-13 19:34:31]

Patchset 2 (id:??) landed as
https://crrev.com/e56855b80edc5ef04735afedc959a629c091825e
Cr-Commit-Position: refs/heads/master@{#418334}