Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 233373002: ARM64: Preserve x8 and x9 when necessary. (Closed)

Created:
6 years, 8 months ago by jbramley
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Preserve x8 and x9 when necessary. Fix a couple of places were x8 and x9 are excluded from lists of saved registers. These are caller-saved registers, so C code can corrupt them. x8 and x9 were originally reserved for debug code in the ARM64 port, so we didn't bother preserving them, but they are now normal allocatable registers. BUG=v8:3263 LOG=N R=rmcilroy@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M src/arm64/assembler-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 6 chunks +11 lines, -13 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbramley
6 years, 8 months ago (2014-04-10 15:22:01 UTC) #1
ulan
lgtm, good catch!
6 years, 8 months ago (2014-04-10 15:42:57 UTC) #2
rmcilroy
6 years, 8 months ago (2014-04-10 15:47:10 UTC) #3
rmcilroy
On 2014/04/10 15:47:10, rmcilroy wrote: lgtm, thanks
6 years, 8 months ago (2014-04-10 15:47:22 UTC) #4
jbramley
6 years, 8 months ago (2014-04-10 15:47:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r20658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698