Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2333723002: Also make the dropdown selection text be multiline. (Closed)

Created:
4 years, 3 months ago by sebsg
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Also make the dropdown selection text be multiline. BUG=637332 Review-Url: https://codereview.chromium.org/2287513002 Cr-Commit-Position: refs/heads/master@{#415286} (cherry picked from commit 1ededfa5db7e0abf94b0e3d89e101b2df3767b5d) Committed: https://chromium.googlesource.com/chromium/src/+/c1ab42fa5d13c8ce283f50973fbe221b6781b68c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -40 lines) Patch
A + chrome/android/java/res/layout/multiline_spinner_item.xml View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 6 chunks +32 lines, -16 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sebsg
4 years, 3 months ago (2016-09-12 14:13:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1ab42fa5d13c8ce283f50973fbe221b6781b68c.

Powered by Google App Engine
This is Rietveld 408576698