Move PathUtils to use ContextUtils.

Move PathUtils to use ContextUtils.

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d
Cr-Commit-Position: refs/heads/master@{#423633}

[Peter Wen, 2016-09-12 19:54:27]

Description was changed from

==========
Move PathUtils to use ContextUtils.

Follow-up CL will remove the extraneous Context parameter.

BUG=644377
==========

to

==========
Move PathUtils to use ContextUtils.

BUG=644377
==========

[Peter Wen, 2016-09-12 19:59:35]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 19:59:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:10:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Wen, 2016-09-13 17:36:18]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:36:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:45:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Peter Wen, 2016-09-19 19:03:01]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:10:29]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Peter Wen, 2016-09-19 21:10:11]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 21:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 22:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 22:36:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Wen, 2016-09-20 14:57:14]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:33:12]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Peter Wen, 2016-09-20 18:02:02]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 18:02:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:41:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Wen, 2016-09-20 20:15:14]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:20:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Wen, 2016-09-21 14:35:00]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 14:35:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 14:37:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 14:37:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Peter Wen, 2016-09-21 14:41:49]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 14:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 15:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 15:20:38]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-09-30 16:53:15]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 18:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 18:27:39]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-09-30 20:11:41]

Description was changed from

==========
Move PathUtils to use ContextUtils.

BUG=644377
==========

to

==========
Move PathUtils to use ContextUtils.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[Peter Wen, 2016-09-30 20:16:07]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:16:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:56:37]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-10-03 17:13:34]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 17:14:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-03 17:15:48]

Description was changed from

==========
Move PathUtils to use ContextUtils.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Move PathUtils to use ContextUtils.

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[Peter Wen, 2016-10-03 17:18:46]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[agrieve, 2016-10-03 18:23:54]

https://codereview.chromium.org/2333713003/diff/220001/base/android/java/src/...
File base/android/java/src/org/chromium/base/PathUtils.java (right):

https://codereview.chromium.org/2333713003/diff/220001/base/android/java/src/...
base/android/java/src/org/chromium/base/PathUtils.java:128: if
(ContextUtils.getApplicationContext() == null) {
nit: Make this an assert so it's removed in release builds?

https://codereview.chromium.org/2333713003/diff/220001/content/shell/android/...
File
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
(right):

https://codereview.chromium.org/2333713003/diff/220001/content/shell/android/...
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
ContextUtils.initApplicationContext(this);
nit: this is already called in the constructor.

[agrieve, 2016-10-03 18:24:09]

lgtm /w nits

[commit-bot: I haz the power, 2016-10-03 19:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:12:51]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-10-03 21:06:25]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 21:07:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-03 21:23:02]

wnwen@chromium.org changed reviewers:
+ nyquist@chromium.org, slan@chromium.org, tedchoc@chromium.org,
torne@chromium.org, xunjieli@chromium.org

[Peter Wen, 2016-10-03 21:23:04]

+tedchoc@ for chrome/android, testing/android, content/, and components/test
OWNERS.
+slan@ for chromecast/ OWNERS.
+xunjieli@ for components/cronet OWNERS.
+torne@ for android_webview/ OWNERS.
+nyquist@ for blimp/ and components/invalidation OWNERS.

https://codereview.chromium.org/2333713003/diff/220001/base/android/java/src/...
File base/android/java/src/org/chromium/base/PathUtils.java (right):

https://codereview.chromium.org/2333713003/diff/220001/base/android/java/src/...
base/android/java/src/org/chromium/base/PathUtils.java:128: if
(ContextUtils.getApplicationContext() == null) {
On 2016/10/03 18:23:54, agrieve wrote:
> nit: Make this an assert so it's removed in release builds?

Done.

https://codereview.chromium.org/2333713003/diff/220001/content/shell/android/...
File
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
(right):

https://codereview.chromium.org/2333713003/diff/220001/content/shell/android/...
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
ContextUtils.initApplicationContext(this);
On 2016/10/03 18:23:54, agrieve wrote:
> nit: this is already called in the constructor.

Done.

[xunjieli, 2016-10-03 21:27:36]

On 2016/10/03 21:23:04, Peter Wen wrote:
> +tedchoc@ for chrome/android, testing/android, content/, and components/test
> OWNERS.
> +slan@ for chromecast/ OWNERS.
> +xunjieli@ for components/cronet OWNERS.

lgtm

> +torne@ for android_webview/ OWNERS.
> +nyquist@ for blimp/ and components/invalidation OWNERS.
> 
>
https://codereview.chromium.org/2333713003/diff/220001/base/android/java/src/...
> File base/android/java/src/org/chromium/base/PathUtils.java (right):
> 
>
https://codereview.chromium.org/2333713003/diff/220001/base/android/java/src/...
> base/android/java/src/org/chromium/base/PathUtils.java:128: if
> (ContextUtils.getApplicationContext() == null) {
> On 2016/10/03 18:23:54, agrieve wrote:
> > nit: Make this an assert so it's removed in release builds?
> 
> Done.
> 
>
https://codereview.chromium.org/2333713003/diff/220001/content/shell/android/...
> File
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
> (right):
> 
>
https://codereview.chromium.org/2333713003/diff/220001/content/shell/android/...
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
> ContextUtils.initApplicationContext(this);
> On 2016/10/03 18:23:54, agrieve wrote:
> > nit: this is already called in the constructor.
> 
> Done.

[Ted C, 2016-10-03 21:43:54]

lgtm

https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
File
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
(right):

https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java:18:
super();
shouldn't need this right since it is implicit?

https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
File
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
(right):

https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX);
agrieve@ is removing the initializeLibraryDependencies method, so you'll
probably need to move this into the constructor.

[commit-bot: I haz the power, 2016-10-03 22:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:48:06]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-10-04 06:17:34]

blimp, components/invalidation lgtm

[Torne, 2016-10-04 12:34:19]

android_webview LGTM

[Peter Wen, 2016-10-04 13:12:43]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 13:12:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-04 13:13:20]

https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
File
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
(right):

https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java:18:
super();
On 2016/10/03 21:43:53, Ted C wrote:
> shouldn't need this right since it is implicit?

Done. Learnt about implicit default constructors today, thanks! :)

https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
File
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
(right):

https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX);
On 2016/10/03 21:43:53, Ted C wrote:
> agrieve@ is removing the initializeLibraryDependencies method, so you'll
> probably need to move this into the constructor.

Done.

[commit-bot: I haz the power, 2016-10-04 14:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 14:32:27]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-10-04 16:16:47]

On 2016/10/04 13:13:20, Peter Wen wrote:
>
https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
> File
>
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
> (right):
> 
>
https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
>
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java:18:
> super();
> On 2016/10/03 21:43:53, Ted C wrote:
> > shouldn't need this right since it is implicit?
> 
> Done. Learnt about implicit default constructors today, thanks! :)
> 
>
https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
> File
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
> (right):
> 
>
https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
> PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX);
> On 2016/10/03 21:43:53, Ted C wrote:
> > agrieve@ is removing the initializeLibraryDependencies method, so you'll
> > probably need to move this into the constructor.
> 
> Done.

Related: Just noticed today that calling any context methods result in a
NullPointerException if you use a ContextWrapper (such as Application) that
hasn't yet had a context attached to it.
So, it might be better to initialize in attachBaseContext() rather than in
application constructors, and add an assert that getBaseContext() != null. wdyt?

[Peter Wen, 2016-10-04 17:05:16]

On 2016/10/04 16:16:47, agrieve 
> Related: Just noticed today that calling any context methods result in a
> NullPointerException if you use a ContextWrapper (such as Application) that
> hasn't yet had a context attached to it.
> So, it might be better to initialize in attachBaseContext() rather than in
> application constructors, and add an assert that getBaseContext() != null.
wdyt?

I think that's a good idea. That way if the context is used between the
constructor and attachBaseContext then a NPE would be meaningful. I'll add the
assert that getBaseContext() != null in ContextUtils#initApplicationContext,
assuming that's what you meant.

[Peter Wen, 2016-10-04 17:19:02]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:19:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:25:31]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ted C, 2016-10-04 17:31:35]

On 2016/10/04 16:16:47, agrieve wrote:
> On 2016/10/04 13:13:20, Peter Wen wrote:
> >
>
https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
> > File
> >
>
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2333713003/diff/240001/components/test/androi...
> >
>
components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java:18:
> > super();
> > On 2016/10/03 21:43:53, Ted C wrote:
> > > shouldn't need this right since it is implicit?
> > 
> > Done. Learnt about implicit default constructors today, thanks! :)
> > 
> >
>
https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
> > File
> >
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2333713003/diff/240001/content/shell/android/...
> >
>
content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java:29:
> > PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX);
> > On 2016/10/03 21:43:53, Ted C wrote:
> > > agrieve@ is removing the initializeLibraryDependencies method, so you'll
> > > probably need to move this into the constructor.
> > 
> > Done.
> 
> Related: Just noticed today that calling any context methods result in a
> NullPointerException if you use a ContextWrapper (such as Application) that
> hasn't yet had a context attached to it.
> So, it might be better to initialize in attachBaseContext() rather than in
> application constructors, and add an assert that getBaseContext() != null.
wdyt?

sgtm as well

[Peter Wen, 2016-10-04 17:34:00]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 17:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:19:44]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2016-10-05 15:43:28]

Ended up adding a simple not null assert in
BaseChromiumApplication#attachBaseContext.

@slan - Friendly ping for chromecast/ OWNERS.

[slan, 2016-10-06 17:42:41]

On 2016/10/05 15:43:28, Peter Wen wrote:
> Ended up adding a simple not null assert in
> BaseChromiumApplication#attachBaseContext.
> 
> @slan - Friendly ping for chromecast/ OWNERS.

lgtm - apologies for the latency!

[Peter Wen, 2016-10-06 17:54:34]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-10-06 17:54:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, torne@chromium.org, xunjieli@chromium.org,
tedchoc@chromium.org, nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2333713003/#ps300001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-06 17:55:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2016-10-06 17:56:17]

On 2016/10/06 17:42:41, slan wrote:
> On 2016/10/05 15:43:28, Peter Wen wrote:
> > Ended up adding a simple not null assert in
> > BaseChromiumApplication#attachBaseContext.
> > 
> > @slan - Friendly ping for chromecast/ OWNERS.
> 
> lgtm - apologies for the latency!

No worries, thanks for the review! :)

[commit-bot: I haz the power, 2016-10-06 19:39:19]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-10-06 19:41:55]

Description was changed from

==========
Move PathUtils to use ContextUtils.

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Move PathUtils to use ContextUtils.

PathUtils used to store its own application context in a static
variable, assuming that the one it was initialized with was the
application context. This can lead to memory leak bugs and with
ContextUtils#getApplicationContext client code does not have to
store its own reference to the application context.

BUG=644377
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d
Cr-Commit-Position: refs/heads/master@{#423633}
==========

[commit-bot: I haz the power, 2016-10-06 19:41:57]

Patchset 16 (id:??) landed as
https://crrev.com/7200e9f34aa2e9006d8ea5540035de744b13d27d
Cr-Commit-Position: refs/heads/master@{#423633}

[sgurun-gerrit only, 2016-10-10 22:53:16]

A revert of this CL (patchset #16 id:300001) has been created in
https://codereview.chromium.org/2405043002/ by sgurun@chromium.org.

The reason for reverting is: Breaking monochrome (chrome not booting up).
reverted part of other breaks not to introduce a conflict.

BUG=644377, 653771.