Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: tests/StreamTest.cpp

Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData* (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/StreamTest.cpp
diff --git a/tests/StreamTest.cpp b/tests/StreamTest.cpp
index 56977822b9db5cb9621c672aab20766c7fd67cd5..e2a183f56a74580cf94005a38d1804e32ad6c765 100644
--- a/tests/StreamTest.cpp
+++ b/tests/StreamTest.cpp
@@ -117,7 +117,7 @@ static void TestWStream(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, ds.getOffset() == 100 * 26);
{
- sk_sp<SkData> data(ds.copyToData());
+ sk_sp<SkData> data = ds.makeCopy();
REPORTER_ASSERT(reporter, 100 * 26 == data->size());
REPORTER_ASSERT(reporter, memcmp(dst, data->data(), data->size()) == 0);
}
@@ -174,15 +174,14 @@ static void TestPackedUInt(skiatest::Reporter* reporter) {
static void TestDereferencingData(SkMemoryStream* memStream) {
memStream->read(nullptr, 0);
memStream->getMemoryBase();
- sk_sp<SkData> data(memStream->copyToData());
+ (void)memStream->makeCopy();
}
static void TestNullData() {
- SkData* nullData = nullptr;
- SkMemoryStream memStream(nullData);
+ SkMemoryStream memStream(nullptr);
TestDereferencingData(&memStream);
- memStream.setData(nullData);
+ memStream.setData(nullptr);
TestDereferencingData(&memStream);
}
@@ -404,8 +403,7 @@ static void stream_copy_test(skiatest::Reporter* reporter,
ERRORF(reporter, "SkStreamCopy failed");
return;
}
- sk_sp<SkData> data(tgt.copyToData());
- tgt.reset();
+ sk_sp<SkData> data(tgt.detachAsData());
if (data->size() != N) {
ERRORF(reporter, "SkStreamCopy incorrect size");
return;
« include/core/SkStream.h ('K') | « tests/PictureTest.cpp ('k') | tests/TypefaceTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698