Implemented scoped invalidation for added/removed RuleSets.

Implemented scoped invalidation for added/removed RuleSets.

Async stylesheet update will schedule invalidation sets based on the
RuleFeatureSets for added/removed stylesheets. Implement the
functionality in StyleEngine for scheduling invalidations in the
stylesheet's TreeScope, including host and slotted elements if
applicable.

R=ericwilligers@chromium.org
BUG=567021
Committed: https://crrev.com/7bff558df449b9b0542b4b617331518f9ae7f36e
Cr-Commit-Position: refs/heads/master@{#420192}

[rune, 2016-09-12 11:22:05]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 11:22:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 11:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 11:24:00]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2016-09-13 01:22:04]

https://codereview.chromium.org/2333693002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleEngine.cpp (right):

https://codereview.chromium.org/2333693002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleEngine.cpp:791:
element.setNeedsStyleRecalc(LocalStyleChange,
StyleChangeReasonForTracing::create(StyleChangeReason::StyleSheetChange));
element.needsStyleRecalc() becomes true, so typeSelectorMatch is redundant.

[rune, 2016-09-13 13:13:53]

I need to revisit this. Invalidation set features for boundary crossing rules
are not currently collected into the stylesheet RuleSet, but added to the
ScopedStyleResolver in addTreeBoundaryCrossingRules. The current code misses
shadow dom v0 boundary crossing rules, and the code for ::slotted is not
correct.

https://codereview.chromium.org/2333693002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StyleEngine.cpp (right):

https://codereview.chromium.org/2333693002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StyleEngine.cpp:791:
element.setNeedsStyleRecalc(LocalStyleChange,
StyleChangeReasonForTracing::create(StyleChangeReason::StyleSheetChange));
On 2016/09/13 01:22:03, Eric Willigers wrote:
> element.needsStyleRecalc() becomes true, so typeSelectorMatch is redundant.

The needsStyleRecalc() is actually wrong, since it will return true for
animation style changes. I think we should just skip the whole check since the
tagRules() lookup is probably as fast as looking up elementAnimations and the
animation style change.

[rune, 2016-09-17 13:48:18]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 13:48:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 15:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 15:01:49]

Dry run: This issue passed the CQ dry run.

[rune, 2016-09-18 20:22:13]

Ready for review.

[rune, 2016-09-20 11:45:03]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:45:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 12:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:57:35]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-09-21 19:50:29]

lgtm

[rune, 2016-09-21 20:10:30]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-09-21 20:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:17:05]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-09-21 23:19:11]

Description was changed from

==========
Implemented scoped invalidation for added/removed RuleSets.

Async stylesheet update will schedule invalidation sets based on the
RuleFeatureSets for added/removed stylesheets. Implement the
functionality in StyleEngine for scheduling invalidations in the
stylesheet's TreeScope, including host and slotted elements if
applicable.

R=ericwilligers@chromium.org
BUG=567021
==========

to

==========
Implemented scoped invalidation for added/removed RuleSets.

Async stylesheet update will schedule invalidation sets based on the
RuleFeatureSets for added/removed stylesheets. Implement the
functionality in StyleEngine for scheduling invalidations in the
stylesheet's TreeScope, including host and slotted elements if
applicable.

R=ericwilligers@chromium.org
BUG=567021

Committed: https://crrev.com/7bff558df449b9b0542b4b617331518f9ae7f36e
Cr-Commit-Position: refs/heads/master@{#420192}
==========

[commit-bot: I haz the power, 2016-09-21 23:19:12]

Patchset 3 (id:??) landed as
https://crrev.com/7bff558df449b9b0542b4b617331518f9ae7f36e
Cr-Commit-Position: refs/heads/master@{#420192}