Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2333673002: Add a test for {connected,disconnected}Callback in HTML Imports (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
Reviewers:
kojii
CC:
blink-reviews, chromium-reviews, dominicc (has gone to gerrit), tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for {connected,disconnected}Callback in HTML Imports This adds a test case for connectedCallback and disconnectedCallback for custom elements in HTML imports. BUG=594918 Committed: https://crrev.com/d9a1945abf1dde3b23e56afb59c24e773340672a Cr-Commit-Position: refs/heads/master@{#418193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/custom-elements/imports/connected-callback.html View 1 chunk +70 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/custom-elements/imports/resources/connected-parsercreate.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/custom-elements/imports/resources/connected-upgrade.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
kochi
PTAL
4 years, 3 months ago (2016-09-13 03:35:56 UTC) #7
kojii
lgtm
4 years, 3 months ago (2016-09-13 07:55:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333673002/1
4 years, 3 months ago (2016-09-13 07:56:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 08:00:48 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 08:02:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9a1945abf1dde3b23e56afb59c24e773340672a
Cr-Commit-Position: refs/heads/master@{#418193}

Powered by Google App Engine
This is Rietveld 408576698