Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: ui/gfx/color_space.h

Issue 2333663003: Add color metadata info to VideoDecoderConfig. (Closed)
Patch Set: Commented the RangeID comment as suggested Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/test/data/colour.webm ('k') | ui/gfx/color_transform.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/color_space.h
diff --git a/ui/gfx/color_space.h b/ui/gfx/color_space.h
index ce02b0aa1b6eb20285884f4040aba5d0bb3701c1..bc5d267164dcb2367ecff7cfce05902ab67f2ca6 100644
--- a/ui/gfx/color_space.h
+++ b/ui/gfx/color_space.h
@@ -116,15 +116,24 @@ class GFX_EXPORT ColorSpace {
LAST = UNKNOWN,
};
- // The h264 spec declares this as bool, so only the the first two values
- // correspond to the h264 spec. Chrome-specific values can start at 2.
- // We use an enum instead of a bool becuase different bit depths may have
- // different definitions of what "limited" means.
+ // This corresponds to the WebM Range enum which is part of WebM color data
+ // (see http://www.webmproject.org/docs/container/#Range).
+ // H.264 only uses a bool, which corresponds to the LIMITED/FULL values.
+ // Chrome-specific values start at 1000.
enum class RangeID : int8_t {
- FULL = 0,
+ // Range is not explicitly specified / unknown.
+ UNSPECIFIED = 0,
+
+ // Limited Rec. 709 color range with RGB values ranging from 16 to 235.
LIMITED = 1,
- LAST = LIMITED
+ // Full RGB color range with RGB valees from 0 to 255.
+ FULL = 2,
+
+ // Range is defined by TransferID/MatrixID.
+ DERIVED = 3,
+
+ LAST = DERIVED
};
ColorSpace();
« no previous file with comments | « media/test/data/colour.webm ('k') | ui/gfx/color_transform.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698