Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: media/formats/webm/webm_stream_parser_unittest.cc

Issue 2333663003: Add color metadata info to VideoDecoderConfig. (Closed)
Patch Set: buildfix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/webm/webm_stream_parser_unittest.cc
diff --git a/media/formats/webm/webm_stream_parser_unittest.cc b/media/formats/webm/webm_stream_parser_unittest.cc
index 03cf928f050b8aab2460fba3d18bedad198e7d39..a8fe7ef3b206b71c694a300b8dee89659b8a4e08 100644
--- a/media/formats/webm/webm_stream_parser_unittest.cc
+++ b/media/formats/webm/webm_stream_parser_unittest.cc
@@ -153,4 +153,42 @@ TEST_F(WebMStreamParserTest, VerifyDetectedTracks_AVText) {
EXPECT_EQ(media_tracks_->tracks()[1]->type(), MediaTrack::Audio);
}
+TEST_F(WebMStreamParserTest, ColourElement) {
+ EXPECT_MEDIA_LOG(testing::HasSubstr("Estimating WebM block duration"))
+ .Times(testing::AnyNumber());
+ StreamParser::InitParameters params(kInfiniteDuration);
+ params.detected_audio_track_count = 0;
+ params.detected_video_track_count = 1;
+ params.detected_text_track_count = 0;
+ ParseWebMFile("colour.webm", params);
+ EXPECT_EQ(media_tracks_->tracks().size(), 1u);
+
+ const auto& video_track = media_tracks_->tracks()[0];
+ EXPECT_EQ(video_track->type(), MediaTrack::Video);
+
+ const VideoDecoderConfig& video_config =
+ media_tracks_->getVideoConfig(video_track->bytestream_track_id());
+ base::Optional<ColorMetadata> metadata = video_config.GetColorMetadata();
+ EXPECT_TRUE(metadata.has_value());
+ EXPECT_EQ(metadata->matrix_coefficients, MatrixCoefficients::kRgb);
+ EXPECT_EQ(metadata->BitsPerChannel, 1u);
+ EXPECT_EQ(metadata->range, Range::kFull);
+ EXPECT_EQ(metadata->transfer_characteristics, TransferCharacteristics::kLog);
+ EXPECT_EQ(metadata->primaries, Primaries::kSmpteSt4281);
+ EXPECT_EQ(metadata->hdr_metadata.MaxCLL, 11u);
+ EXPECT_EQ(metadata->hdr_metadata.MaxFALL, 12u);
+
+ const MasteringMetadata& mmdata = metadata->hdr_metadata.mastering_metadata;
+ EXPECT_FLOAT_EQ(mmdata.PrimaryRChromaticityX, 0.1f);
+ EXPECT_FLOAT_EQ(mmdata.PrimaryRChromaticityY, 0.2f);
+ EXPECT_FLOAT_EQ(mmdata.PrimaryGChromaticityX, 0.1f);
+ EXPECT_FLOAT_EQ(mmdata.PrimaryGChromaticityY, 0.2f);
+ EXPECT_FLOAT_EQ(mmdata.PrimaryBChromaticityX, 0.1f);
+ EXPECT_FLOAT_EQ(mmdata.PrimaryBChromaticityY, 0.2f);
+ EXPECT_FLOAT_EQ(mmdata.WhitePointChromaticityX, 0.1f);
+ EXPECT_FLOAT_EQ(mmdata.WhitePointChromaticityY, 0.2f);
+ EXPECT_EQ(mmdata.LuminanceMax, 40);
+ EXPECT_EQ(mmdata.LuminanceMin, 30);
+}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698