Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2333663002: [turbofan] Do constant folding for Float64Pow. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do constant folding for Float64Pow. Also unify the Pow implementation somewhat. There are still some inconsistencies with the FPU version for x64/ia32, but that has to be resolved separately. R=ahaas@chromium.org, mvstanton@chromium.org BUG=v8:5086 Committed: https://crrev.com/e786ef2474f6e50793df6d97e3ecd646652cf29a Cr-Commit-Position: refs/heads/master@{#39368}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback. #

Patch Set 3 : Make sure to have exponent 0/-0 properly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/utils.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/wasm/wasm-external-refs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-12 10:39:48 UTC) #1
ahaas
On 2016/09/12 at 10:39:48, bmeurer wrote: > lgtm with nit.
4 years, 3 months ago (2016-09-12 10:44:12 UTC) #4
ahaas
https://codereview.chromium.org/2333663002/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc File test/unittests/compiler/machine-operator-reducer-unittest.cc (right): https://codereview.chromium.org/2333663002/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc#newcode1788 test/unittests/compiler/machine-operator-reducer-unittest.cc:1788: Nit: could you add a test for x ** ...
4 years, 3 months ago (2016-09-12 10:45:24 UTC) #5
mvstanton
Yay, less TODOs :P. lgtm.
4 years, 3 months ago (2016-09-12 10:47:43 UTC) #6
Benedikt Meurer
https://codereview.chromium.org/2333663002/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc File test/unittests/compiler/machine-operator-reducer-unittest.cc (right): https://codereview.chromium.org/2333663002/diff/1/test/unittests/compiler/machine-operator-reducer-unittest.cc#newcode1788 test/unittests/compiler/machine-operator-reducer-unittest.cc:1788: On 2016/09/12 10:45:23, ahaas wrote: > Nit: could you ...
4 years, 3 months ago (2016-09-12 10:52:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333663002/20001
4 years, 3 months ago (2016-09-12 10:52:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/8573) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-12 11:45:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333663002/40001
4 years, 3 months ago (2016-09-13 06:43:23 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-13 07:10:03 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 07:10:50 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e786ef2474f6e50793df6d97e3ecd646652cf29a
Cr-Commit-Position: refs/heads/master@{#39368}

Powered by Google App Engine
This is Rietveld 408576698