Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2333623003: Convert remaining focus tests in shadow-dom to use testharness.js (Closed)

Created:
4 years, 3 months ago by kochi
Modified:
4 years, 3 months ago
Reviewers:
hayato
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert remaining focus tests in shadow-dom to use testharness.js The following tests are converted to use testharness.js from js-test.js in LayoutTests/shadow-dom/. * attach-shadow-with-parameter.html * focus-slide-on-shadow-host.html * focus-shadowhost-display-none.html For attach-shadow-with-parameter.html, I added some return value checks, but otherwise almost straightforward conversion to testharness.js API. Committed: https://crrev.com/fd364c78285a1351b365de75d3040f4e4457fa37 Cr-Commit-Position: refs/heads/master@{#418770}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
kochi
PTAL
4 years, 3 months ago (2016-09-14 08:43:32 UTC) #9
hayato
lgtm
4 years, 3 months ago (2016-09-15 01:53:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333623003/1
4 years, 3 months ago (2016-09-15 02:11:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 03:24:36 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 03:29:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd364c78285a1351b365de75d3040f4e4457fa37
Cr-Commit-Position: refs/heads/master@{#418770}

Powered by Google App Engine
This is Rietveld 408576698