Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2333593002: Revert of Make secondary abi work for component build (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
michaelbai, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make secondary abi work for component build (patchset #2 id:110001 of https://codereview.chromium.org/2326973003/ ) Reason for revert: Doesn't implement a guarded import as described. Leads to the same problems as on first CL downstream: https://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/24283/steps/generate_build_files/logs/stdout Original issue's description: > Reland of Make secondary abi work for component build > > Reverted in: > https://codereview.chromium.org/2327063002/ > > Reason for reland: > Now guards non-build import behind enable_java_templates > > TBR=michaelbai,machenbach > BUG=622855 > > Committed: https://crrev.com/2ded0b9b26d3cfdd3068b36c28d157c87cb8ab39 > Cr-Commit-Position: refs/heads/master@{#417597} TBR=michaelbai@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622855 Committed: https://crrev.com/4ecdcbc6d42854e4a710f208d0a3875d75dafa90 Cr-Commit-Position: refs/heads/master@{#417897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -170 lines) Patch
M build/android/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/write_build_config.py View 3 chunks +4 lines, -21 lines 0 comments Download
M build/config/android/internal_rules.gni View 6 chunks +2 lines, -60 lines 0 comments Download
M build/config/android/rules.gni View 8 chunks +34 lines, -85 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of Make secondary abi work for component build
4 years, 3 months ago (2016-09-12 07:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333593002/1
4 years, 3 months ago (2016-09-12 07:30:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 09:07:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ecdcbc6d42854e4a710f208d0a3875d75dafa90 Cr-Commit-Position: refs/heads/master@{#417897}
4 years, 3 months ago (2016-09-12 09:09:24 UTC) #7
agrieve
4 years, 3 months ago (2016-09-12 14:02:25 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2335663002/ by agrieve@chromium.org.

The reason for reverting is: For real this time..

Powered by Google App Engine
This is Rietveld 408576698