third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html - Issue 2333583002: [css-grid] Update intrinsic size for the extra sizing alg iteration.

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html

Issue 2333583002: [css-grid] Update intrinsic size for the extra sizing alg iteration. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html

index 04b6f84c57d4f54607f86da21ad69514451bd9ff..16ffc778abcbfeffc1490c4da8fbf3edb887751b 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html

@@ -49,7 +49,7 @@ body {

<p>Grid width under <b>min-content</b> constrain and <b>fixed</b> height.<br> All grid items sized with <b>min-{width, height} auto</b>.<br> Orthogonal green row track assumed as infinity, hence 10px for the column track. Actual row tracks size is different, hence overflowing. </p>

- <div class="grid itemsStart contentStart min-content height200" data-expected-width="50" data-expected-height="200">

+ <div class="grid itemsStart contentStart min-content height200" data-expected-width="70" data-expected-height="200">

<div class="verticalLR firstRowSecondColumn" data-offset-x="30" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

@@ -58,18 +58,18 @@ body {

<p>Grid width under <b>max-content</b> constrain and <b>fixed</b> height.<br> All grid items sized with <b>min-{width, height} auto</b>.<br> Parallel blue column track sized as its max of 150x, while Orthogonal green row, assumed as infinity, sized as 10px. Since actual row tracks size is different, green column track will occupy some space initally assigned to the blue one.</p>

- <div class="grid itemsStart contentStart max-content height200" data-expected-width="170" data-expected-height="200">

- <div class="firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="130" data-expected-height="20">XX XXX X XXX XX</div>

- <div class="verticalLR firstRowSecondColumn" data-offset-x="130" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

+ <div class="grid itemsStart contentStart max-content height200" data-expected-width="190" data-expected-height="200">

+ <div class="firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="150" data-expected-height="10">XX XXX X XXX XX</div>

+ <div class="verticalLR firstRowSecondColumn" data-offset-x="150" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

</div>

<p>Grid width under <b>fit-content</b> constrain and <b>fixed</b> height.<br >All grid items sized with <b>min-{width, height} auto</b>.<br> Since we use assumed row tracks sizes, minimum and maximum will be the same, hence fit-content will produce the same result than max-content.</p>

- <div class="grid itemsStart contentStart fit-content height200" data-expected-width="170" data-expected-height="200">

- <div class="firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="130" data-expected-height="20">XX XXX X XXX XX</div>

- <div class="verticalLR firstRowSecondColumn" data-offset-x="130" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

+ <div class="grid itemsStart contentStart fit-content height200" data-expected-width="190" data-expected-height="200">

+ <div class="firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="150" data-expected-height="10">XX XXX X XXX XX</div>

+ <div class="verticalLR firstRowSecondColumn" data-offset-x="150" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

</div>

@@ -123,9 +123,9 @@ body {

<p>Grid width under <b>max-content</b> constrain and <b>fixed</b> height.<br> All grid items sized with <b>min-width: 0px, min-height: auto</b>.<br> Since container is sized under max-content, tracks will use its maximum size.</p>

- <div class="grid itemsStart contentStart max-content height200" data-expected-width="170" data-expected-height="200">

- <div class="minWidthZero firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="130" data-expected-height="20">XX XXX X XXX XX</div>

- <div class="minWidthZero verticalLR firstRowSecondColumn" data-offset-x="130" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

+ <div class="grid itemsStart contentStart max-content height200" data-expected-width="190" data-expected-height="200">

+ <div class="minWidthZero firstRowFirstColumn" data-offset-x="0" data-offset-y="0" data-expected-width="150" data-expected-height="10">XX XXX X XXX XX</div>

+ <div class="minWidthZero verticalLR firstRowSecondColumn" data-offset-x="150" data-offset-y="0" data-expected-width="40" data-expected-height="105">X XXX XX XXXXX XX XXX X XXXX X XX</div>

</div>